added Percent (not as Measurement) - #21
Conversation
NeedleInAJayStack
left a comment
There was a problem hiding this comment.
Hey sorry about the delay in review. This is awesome! Thanks!
I see you've added % into the unit system. I think that might be all we need for the parser to work correctly, but it may not use the correct +/- arithmetic. Could we add a test to validate its behavior?
Thanks again!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
wildthink
commented
Sep 14, 2025
You were right (it appears :-) ), adding in the Percent as you suggested makes the parser happy and I updated the Expression solver correctly -- at least my tests pass :-) |
NeedleInAJayStack
left a comment
There was a problem hiding this comment.
Thanks again @wildthink
Uh oh!
There was an error while loading. Please reload this page.
If you like this approach, I'll fully document it for a formal pull request.
I have some questions/ideas about it could be fully integrated into the Parser, etc.