httpClient inherits Grafana settings - #52
Merged
Merged
Conversation
By using `grafana-plugin-sdk-go/backend/httpclient`, the datasource automatically respects Grafana's proxy / Private Data source Connect settings, request timeouts, and tracing.
This depends on a single channel instead of two channels and a wait group.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the datasource creation to use
grafana-plugin-sdk-go/backend/httpclient, which respects Grafana's proxy / Private Data source Connect settings, request timeouts, and tracing.It also refactors some error formatting and concurrency.