Skip to content

Feature/migratenetmq4 samples - #18

Open
drr00t wants to merge 17 commits into
NetMQ:masterfrom
drr00t:feature/migratenetmq4-helloworld
Open

Feature/migratenetmq4 samples#18
drr00t wants to merge 17 commits into
NetMQ:masterfrom
drr00t:feature/migratenetmq4-helloworld

Conversation

@drr00t

@drr00tdrr00t commented Sep 4, 2021

Copy link
Copy Markdown

No description provided.

@drr00tdrr00t changed the title Feature/migratenetmq4 Feature/migratenetmq4 samplesSep 4, 2021
drewnoakes
drewnoakes reviewed Sep 6, 2021
View reviewed changes

@drewnoakesdrewnoakes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone who works on the Visual Studio project system, I love to see this kind of migration. Thanks!

A few comments here for things to fix up before we can merge this.

Comment threadsrc/Beacon/BeaconDemo/BeaconDemo.csproj Outdated
Comment threadsrc/Beacon/BeaconDemo/BeaconDemo.csproj Outdated
Comment threadsrc/Beacon/BeaconDemo/BeaconDemo.csproj Outdated
Comment thread...liability (Freelance Pattern)/Model One/Freelance.ModelOne.Client/Properties/AssemblyInfo.cs
Comment threadsrc/Majordomo/MDPClientAsyncExample/MDPClientAsyncExample.csproj Outdated
Comment threadsrc/Beacon/BeaconDemo/BeaconDemo.csproj
@drr00t
changes from review:
535cbff
- added Build props file for solution
- fixed framework supported versions
- remove duplicated netcoreapp3.1
@drr00t
changes:
c90f4b7
- update Titanic Pattern examples
- removed empty properties directory from MPDClientAsyncExample
@drr00t
drr00t marked this pull request as draft September 6, 2021 19:48
@drr00t

drr00t commented Sep 7, 2021

Copy link
Copy Markdown
Author

@drewnoakes i think it's for review now, but i'm didn't port two last samples Multitheading and LazyPirate.Client2 those two still broked:

  • Multitheading/Multithreaded Service: need more work because of changes in NetMQQueue implementation
  • Pirate Pattern/LazyPirate.Client2: need more work because of changes in the style of pub-sub implementation.

@drr00t
drr00t marked this pull request as ready for review September 7, 2021 16:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drewnoakesdrewnoakesdrewnoakes left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drr00t@drewnoakes