Uh oh!
There was an error while loading. Please reload this page.
ident: make Name's inner Vec private - #171
Open
pcnofelt wants to merge 1 commit into
Open
Conversation
Make Name's inner Vec private so callers can't construct an empty Name and break the invariant that name helpers like first_label() rely on. FromStr already enforces this; the public tuple field was the only way to bypass it. Update the code that was still reaching into the tuple field to build names by parsing instead, refresh the interface doc to describe Name as opaque, and switch first_label() to the local assert() helper for this invariant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
Name's innerVec<String>private.Addresses linear issue IM-55
Why
Name assumes it always has at least one label. FromStr enforces that, but the public tuple field let callers write Name(vec![]) directly and bypass validation, which could lead to a runtime panic in helpers like first_label(). Making the field private closes that gap, so the invariant holds by construction.
Changes
After this change, code outside src/ident.rs no longer constructs Name(...) or reads .0.
🤖 Generated with Claude Code