Uh oh!
There was an error while loading. Please reload this page.
connect: switch to aws_lc_rs as crypto provider for rustls - #173
Closed
patricklyc wants to merge 1 commit into
Closed
connect: switch to aws_lc_rs as crypto provider for rustls#173patricklyc wants to merge 1 commit into
patricklyc wants to merge 1 commit into
Conversation
Previously, we used RustCrypto as the crypto provider for rustls. It was considered inadequate because it is not production- ready (the integration is in alpha state), relatively slow and has not been externally audited. The candidates for replacement, aws_lc_rs and ring were evaluated by the following criteria: - Reasonably fast - Production ready - Supports ed25519 keys - Easy to build - Works everywhere - Statically linked binary - Externally audited - FIPS support (optional) The only option for FIPS support, aws-lc-fips-sys, failed to build so this point of consideration was discarded. Both candidates fit all criteria. aws_lc_rs won out for being the new default of the rustls project and its more active maintenance, while the only additional build dependency is a C compiler. This commit removes RustCrypto as a dependency. The explicitly configured builders in src/connect.rs were switched over. Any other usage of rustls will fall back to the default provider, aws_lc_rs. flake.nix was updated to use the musl toolchain to resolve correct headers. The changes inject the appropriate musl cross-compilation environment variables. Addresses IM-97 and IM-57.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we used RustCrypto as the crypto provider for rustls. It was considered inadequate because it is not production- ready (the integration is in alpha state), relatively slow and has not been externally audited.
The candidates for replacement, aws_lc_rs and ring were evaluated by the following criteria:
The only option for FIPS support, aws-lc-fips-sys, failed to build so this point of consideration was discarded.
Both candidates fit all criteria. aws_lc_rs won out for being the new default of the rustls project and its more active maintenance, while the only additional build dependency is a C compiler.
This commit removes RustCrypto as a dependency. The explicitly configured builders in src/connect.rs were switched over. Any other usage of rustls will fall back to the default provider, aws_lc_rs.
Addresses IM-97 and IM-57.