Uh oh!
There was an error while loading. Please reload this page.
Fix inconsistency in README.md - #45
Merged
Merged
Conversation
In the pt.sor file the conditionals are set for "pt-BR" language code, so it seems that by default the European Portuguese version is used, and for Brazilian one "pt-BR" should be explicitly specified.
laszlonemeth
commented
Nov 19, 2018
Contributor
Thanks for your fix! László |
aricaldeira added a commit
to aricaldeira/libnumbertext
that referenced
this pull request
Feb 3, 2023
Line Numbertext#45 - Using comma to separate groups: spellout -l pt-BR 123456789 before: cento e vinte e três milhões quatrocentos e cinquenta e seis mil setecentos e oitenta e nove after: cento e vinte e três milhões, quatrocentos e cinquenta e seis mil, setecentos e oitenta e nove Line #141 - Adding ordinal zero spellout -l pt-BR -p ordinal 0 before: after: zerésimo Deleted line #187 - Portuguese doesn't use "primer" like Spanish Lines #187 and #189 - Brazil doesn't add the dot before de ª and º symbols spellout -l pt-BR -p ordinal-number 10 before: 10.º after: 10º
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the pt.sor file the conditionals are set for "pt-BR" language code,
so it seems that by default the European Portuguese version is used,
and for Brazilian one "pt-BR" should be explicitly specified.