Skip to content

Captitalise key words, update guidance to rfc8174 - #1149

Merged
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords
Jun 9, 2017
Merged

Captitalise key words, update guidance to rfc8174#1149
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords

Conversation

@MikeRalphson

Copy link
Copy Markdown
Member

More nit-picking / doc cleanup ;)

  • Update the guidance text on key words to clarify only uppercase instances are to be interpreted as key words - this helps with ambguity over 'may' meaning 'might' and 'MAY' meaning 'it is permitted', 'not all ... must be' etc.
  • Update guidance to reference RFC8174
  • Uppercase key words where apparently needed
  • Make use of Required. / Required. / Required consistent => REQUIRED
  • Change one * to \* to fix an ambiguity over italic text and aid editing the spec in Vim's markdown syntax highlighting mode (other editors are probably available)
  • Erroneous whitespace has been removed only where it was on a line already being modified.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of linking the .txt version, I would recommend the HTML one.

@ePaulePaulJun 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template in RFC8174 says to actually mention both RFCs (and the BCP number):

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I hesitated on that and went with brevity over having the three links, but can amend.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the word "REQUIRED" here actually conforms to RFC 2119, as it doesn't prescribe any behavior.
Maybe the initial paragraph referencing the RFCs and listing the keywords, or the first paragraph under "Schema" should get an additional sentence like this:

A sentence consisting of just the word REQUIRED in a field definition means that including the field is REQUIRED when sending the containing object.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to RFC8174, should the full language be:

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're editing this line, would you want to also make it one sentence per line?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think elsewhere table cells are always written on one line?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table cells have to be one line. At least in the past that was the case.

@RobDolinMS

Copy link
Copy Markdown
Contributor

Thank you @MikeRalphson for this PR. I'm a fan of the clear use of CAPITALIZATION to indicate BCP14 words. I added two suggestions on specific lines.

@webron

Copy link
Copy Markdown
Member

I've yet had a chance to review the PR but something did catch my eye. The 'Required.' in field descriptions is our indication of a required field. It should not be capitalized.

@MikeRalphson

MikeRalphson commented Jun 9, 2017

Copy link
Copy Markdown
MemberAuthor

The 'Required.' in field descriptions is our indication of a required field.

Well, yes, obviously. ;)

It should not be capitalized.

Happy to revert, but in what sense does Required. not "mean that the definition is an absolute requirement of the specification." ?

I specifically wanted to avoid increasing ambiguity by saying REQUIRED was only a key word when capitalised, then having it not capitalised where it does in fact mandate behaviour.

We could add extra wording e.g. as suggested by @ePaul .

@webron

Copy link
Copy Markdown
Member

Perhaps I shouldn't have jumped before reading the entire PR and conversation - I just didn't want extra work to be put into it for nothing. Unfortunately, I can't review it all right now.

@RobDolinMS

Copy link
Copy Markdown
Contributor

#TDC @RobDolinMS and @fehguy are both thumbs-up.

@RobDolinMS
RobDolinMS merged commit 5471a18 into OAI:OpenAPI.nextJun 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MikeRalphson@RobDolinMS@webron@darrelmiller@ePaul
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Captitalise key words, update guidance to rfc8174 by MikeRalphson · Pull Request #1149 · OAI/OpenAPI-Specification · GitHub
Skip to content

Captitalise key words, update guidance to rfc8174 - #1149

Merged
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords
Jun 9, 2017
Merged

Captitalise key words, update guidance to rfc8174#1149
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords

Conversation

@MikeRalphson

Copy link
Copy Markdown
Member

More nit-picking / doc cleanup ;)

  • Update the guidance text on key words to clarify only uppercase instances are to be interpreted as key words - this helps with ambguity over 'may' meaning 'might' and 'MAY' meaning 'it is permitted', 'not all ... must be' etc.
  • Update guidance to reference RFC8174
  • Uppercase key words where apparently needed
  • Make use of Required. / Required. / Required consistent => REQUIRED
  • Change one * to \* to fix an ambiguity over italic text and aid editing the spec in Vim's markdown syntax highlighting mode (other editors are probably available)
  • Erroneous whitespace has been removed only where it was on a line already being modified.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of linking the .txt version, I would recommend the HTML one.

@ePaulePaulJun 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template in RFC8174 says to actually mention both RFCs (and the BCP number):

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I hesitated on that and went with brevity over having the three links, but can amend.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the word "REQUIRED" here actually conforms to RFC 2119, as it doesn't prescribe any behavior.
Maybe the initial paragraph referencing the RFCs and listing the keywords, or the first paragraph under "Schema" should get an additional sentence like this:

A sentence consisting of just the word REQUIRED in a field definition means that including the field is REQUIRED when sending the containing object.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to RFC8174, should the full language be:

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're editing this line, would you want to also make it one sentence per line?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think elsewhere table cells are always written on one line?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table cells have to be one line. At least in the past that was the case.

@RobDolinMS

Copy link
Copy Markdown
Contributor

Thank you @MikeRalphson for this PR. I'm a fan of the clear use of CAPITALIZATION to indicate BCP14 words. I added two suggestions on specific lines.

@webron

Copy link
Copy Markdown
Member

I've yet had a chance to review the PR but something did catch my eye. The 'Required.' in field descriptions is our indication of a required field. It should not be capitalized.

@MikeRalphson

MikeRalphson commented Jun 9, 2017

Copy link
Copy Markdown
MemberAuthor

The 'Required.' in field descriptions is our indication of a required field.

Well, yes, obviously. ;)

It should not be capitalized.

Happy to revert, but in what sense does Required. not "mean that the definition is an absolute requirement of the specification." ?

I specifically wanted to avoid increasing ambiguity by saying REQUIRED was only a key word when capitalised, then having it not capitalised where it does in fact mandate behaviour.

We could add extra wording e.g. as suggested by @ePaul .

@webron

Copy link
Copy Markdown
Member

Perhaps I shouldn't have jumped before reading the entire PR and conversation - I just didn't want extra work to be put into it for nothing. Unfortunately, I can't review it all right now.

@RobDolinMS

Copy link
Copy Markdown
Contributor

#TDC @RobDolinMS and @fehguy are both thumbs-up.

@RobDolinMS
RobDolinMS merged commit 5471a18 into OAI:OpenAPI.nextJun 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MikeRalphson@RobDolinMS@webron@darrelmiller@ePaul
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Captitalise key words, update guidance to rfc8174 by MikeRalphson · Pull Request #1149 · OAI/OpenAPI-Specification · GitHub
Skip to content

Captitalise key words, update guidance to rfc8174 - #1149

Merged
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords
Jun 9, 2017
Merged

Captitalise key words, update guidance to rfc8174#1149
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords

Conversation

@MikeRalphson

Copy link
Copy Markdown
Member

More nit-picking / doc cleanup ;)

  • Update the guidance text on key words to clarify only uppercase instances are to be interpreted as key words - this helps with ambguity over 'may' meaning 'might' and 'MAY' meaning 'it is permitted', 'not all ... must be' etc.
  • Update guidance to reference RFC8174
  • Uppercase key words where apparently needed
  • Make use of Required. / Required. / Required consistent => REQUIRED
  • Change one * to \* to fix an ambiguity over italic text and aid editing the spec in Vim's markdown syntax highlighting mode (other editors are probably available)
  • Erroneous whitespace has been removed only where it was on a line already being modified.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of linking the .txt version, I would recommend the HTML one.

@ePaulePaulJun 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template in RFC8174 says to actually mention both RFCs (and the BCP number):

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I hesitated on that and went with brevity over having the three links, but can amend.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the word "REQUIRED" here actually conforms to RFC 2119, as it doesn't prescribe any behavior.
Maybe the initial paragraph referencing the RFCs and listing the keywords, or the first paragraph under "Schema" should get an additional sentence like this:

A sentence consisting of just the word REQUIRED in a field definition means that including the field is REQUIRED when sending the containing object.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to RFC8174, should the full language be:

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're editing this line, would you want to also make it one sentence per line?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think elsewhere table cells are always written on one line?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table cells have to be one line. At least in the past that was the case.

@RobDolinMS

Copy link
Copy Markdown
Contributor

Thank you @MikeRalphson for this PR. I'm a fan of the clear use of CAPITALIZATION to indicate BCP14 words. I added two suggestions on specific lines.

@webron

Copy link
Copy Markdown
Member

I've yet had a chance to review the PR but something did catch my eye. The 'Required.' in field descriptions is our indication of a required field. It should not be capitalized.

@MikeRalphson

MikeRalphson commented Jun 9, 2017

Copy link
Copy Markdown
MemberAuthor

The 'Required.' in field descriptions is our indication of a required field.

Well, yes, obviously. ;)

It should not be capitalized.

Happy to revert, but in what sense does Required. not "mean that the definition is an absolute requirement of the specification." ?

I specifically wanted to avoid increasing ambiguity by saying REQUIRED was only a key word when capitalised, then having it not capitalised where it does in fact mandate behaviour.

We could add extra wording e.g. as suggested by @ePaul .

@webron

Copy link
Copy Markdown
Member

Perhaps I shouldn't have jumped before reading the entire PR and conversation - I just didn't want extra work to be put into it for nothing. Unfortunately, I can't review it all right now.

@RobDolinMS

Copy link
Copy Markdown
Contributor

#TDC @RobDolinMS and @fehguy are both thumbs-up.

@RobDolinMS
RobDolinMS merged commit 5471a18 into OAI:OpenAPI.nextJun 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MikeRalphson@RobDolinMS@webron@darrelmiller@ePaul
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Captitalise key words, update guidance to rfc8174 by MikeRalphson · Pull Request #1149 · OAI/OpenAPI-Specification · GitHub
Skip to content

Captitalise key words, update guidance to rfc8174 - #1149

Merged
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords
Jun 9, 2017
Merged

Captitalise key words, update guidance to rfc8174#1149
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords

Conversation

@MikeRalphson

Copy link
Copy Markdown
Member

More nit-picking / doc cleanup ;)

  • Update the guidance text on key words to clarify only uppercase instances are to be interpreted as key words - this helps with ambguity over 'may' meaning 'might' and 'MAY' meaning 'it is permitted', 'not all ... must be' etc.
  • Update guidance to reference RFC8174
  • Uppercase key words where apparently needed
  • Make use of Required. / Required. / Required consistent => REQUIRED
  • Change one * to \* to fix an ambiguity over italic text and aid editing the spec in Vim's markdown syntax highlighting mode (other editors are probably available)
  • Erroneous whitespace has been removed only where it was on a line already being modified.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of linking the .txt version, I would recommend the HTML one.

@ePaulePaulJun 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template in RFC8174 says to actually mention both RFCs (and the BCP number):

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I hesitated on that and went with brevity over having the three links, but can amend.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the word "REQUIRED" here actually conforms to RFC 2119, as it doesn't prescribe any behavior.
Maybe the initial paragraph referencing the RFCs and listing the keywords, or the first paragraph under "Schema" should get an additional sentence like this:

A sentence consisting of just the word REQUIRED in a field definition means that including the field is REQUIRED when sending the containing object.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to RFC8174, should the full language be:

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're editing this line, would you want to also make it one sentence per line?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think elsewhere table cells are always written on one line?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table cells have to be one line. At least in the past that was the case.

@RobDolinMS

Copy link
Copy Markdown
Contributor

Thank you @MikeRalphson for this PR. I'm a fan of the clear use of CAPITALIZATION to indicate BCP14 words. I added two suggestions on specific lines.

@webron

Copy link
Copy Markdown
Member

I've yet had a chance to review the PR but something did catch my eye. The 'Required.' in field descriptions is our indication of a required field. It should not be capitalized.

@MikeRalphson

MikeRalphson commented Jun 9, 2017

Copy link
Copy Markdown
MemberAuthor

The 'Required.' in field descriptions is our indication of a required field.

Well, yes, obviously. ;)

It should not be capitalized.

Happy to revert, but in what sense does Required. not "mean that the definition is an absolute requirement of the specification." ?

I specifically wanted to avoid increasing ambiguity by saying REQUIRED was only a key word when capitalised, then having it not capitalised where it does in fact mandate behaviour.

We could add extra wording e.g. as suggested by @ePaul .

@webron

Copy link
Copy Markdown
Member

Perhaps I shouldn't have jumped before reading the entire PR and conversation - I just didn't want extra work to be put into it for nothing. Unfortunately, I can't review it all right now.

@RobDolinMS

Copy link
Copy Markdown
Contributor

#TDC @RobDolinMS and @fehguy are both thumbs-up.

@RobDolinMS
RobDolinMS merged commit 5471a18 into OAI:OpenAPI.nextJun 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MikeRalphson@RobDolinMS@webron@darrelmiller@ePaul
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Captitalise key words, update guidance to rfc8174 by MikeRalphson · Pull Request #1149 · OAI/OpenAPI-Specification · GitHub
Skip to content

Captitalise key words, update guidance to rfc8174 - #1149

Merged
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords
Jun 9, 2017
Merged

Captitalise key words, update guidance to rfc8174#1149
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords

Conversation

@MikeRalphson

Copy link
Copy Markdown
Member

More nit-picking / doc cleanup ;)

  • Update the guidance text on key words to clarify only uppercase instances are to be interpreted as key words - this helps with ambguity over 'may' meaning 'might' and 'MAY' meaning 'it is permitted', 'not all ... must be' etc.
  • Update guidance to reference RFC8174
  • Uppercase key words where apparently needed
  • Make use of Required. / Required. / Required consistent => REQUIRED
  • Change one * to \* to fix an ambiguity over italic text and aid editing the spec in Vim's markdown syntax highlighting mode (other editors are probably available)
  • Erroneous whitespace has been removed only where it was on a line already being modified.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of linking the .txt version, I would recommend the HTML one.

@ePaulePaulJun 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template in RFC8174 says to actually mention both RFCs (and the BCP number):

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I hesitated on that and went with brevity over having the three links, but can amend.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the word "REQUIRED" here actually conforms to RFC 2119, as it doesn't prescribe any behavior.
Maybe the initial paragraph referencing the RFCs and listing the keywords, or the first paragraph under "Schema" should get an additional sentence like this:

A sentence consisting of just the word REQUIRED in a field definition means that including the field is REQUIRED when sending the containing object.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to RFC8174, should the full language be:

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're editing this line, would you want to also make it one sentence per line?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think elsewhere table cells are always written on one line?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table cells have to be one line. At least in the past that was the case.

@RobDolinMS

Copy link
Copy Markdown
Contributor

Thank you @MikeRalphson for this PR. I'm a fan of the clear use of CAPITALIZATION to indicate BCP14 words. I added two suggestions on specific lines.

@webron

Copy link
Copy Markdown
Member

I've yet had a chance to review the PR but something did catch my eye. The 'Required.' in field descriptions is our indication of a required field. It should not be capitalized.

@MikeRalphson

MikeRalphson commented Jun 9, 2017

Copy link
Copy Markdown
MemberAuthor

The 'Required.' in field descriptions is our indication of a required field.

Well, yes, obviously. ;)

It should not be capitalized.

Happy to revert, but in what sense does Required. not "mean that the definition is an absolute requirement of the specification." ?

I specifically wanted to avoid increasing ambiguity by saying REQUIRED was only a key word when capitalised, then having it not capitalised where it does in fact mandate behaviour.

We could add extra wording e.g. as suggested by @ePaul .

@webron

Copy link
Copy Markdown
Member

Perhaps I shouldn't have jumped before reading the entire PR and conversation - I just didn't want extra work to be put into it for nothing. Unfortunately, I can't review it all right now.

@RobDolinMS

Copy link
Copy Markdown
Contributor

#TDC @RobDolinMS and @fehguy are both thumbs-up.

@RobDolinMS
RobDolinMS merged commit 5471a18 into OAI:OpenAPI.nextJun 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MikeRalphson@RobDolinMS@webron@darrelmiller@ePaul
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Captitalise key words, update guidance to rfc8174 by MikeRalphson · Pull Request #1149 · OAI/OpenAPI-Specification · GitHub
Skip to content

Captitalise key words, update guidance to rfc8174 - #1149

Merged
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords
Jun 9, 2017
Merged

Captitalise key words, update guidance to rfc8174#1149
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords

Conversation

@MikeRalphson

Copy link
Copy Markdown
Member

More nit-picking / doc cleanup ;)

  • Update the guidance text on key words to clarify only uppercase instances are to be interpreted as key words - this helps with ambguity over 'may' meaning 'might' and 'MAY' meaning 'it is permitted', 'not all ... must be' etc.
  • Update guidance to reference RFC8174
  • Uppercase key words where apparently needed
  • Make use of Required. / Required. / Required consistent => REQUIRED
  • Change one * to \* to fix an ambiguity over italic text and aid editing the spec in Vim's markdown syntax highlighting mode (other editors are probably available)
  • Erroneous whitespace has been removed only where it was on a line already being modified.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of linking the .txt version, I would recommend the HTML one.

@ePaulePaulJun 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template in RFC8174 says to actually mention both RFCs (and the BCP number):

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I hesitated on that and went with brevity over having the three links, but can amend.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the word "REQUIRED" here actually conforms to RFC 2119, as it doesn't prescribe any behavior.
Maybe the initial paragraph referencing the RFCs and listing the keywords, or the first paragraph under "Schema" should get an additional sentence like this:

A sentence consisting of just the word REQUIRED in a field definition means that including the field is REQUIRED when sending the containing object.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to RFC8174, should the full language be:

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're editing this line, would you want to also make it one sentence per line?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think elsewhere table cells are always written on one line?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table cells have to be one line. At least in the past that was the case.

@RobDolinMS

Copy link
Copy Markdown
Contributor

Thank you @MikeRalphson for this PR. I'm a fan of the clear use of CAPITALIZATION to indicate BCP14 words. I added two suggestions on specific lines.

@webron

Copy link
Copy Markdown
Member

I've yet had a chance to review the PR but something did catch my eye. The 'Required.' in field descriptions is our indication of a required field. It should not be capitalized.

@MikeRalphson

MikeRalphson commented Jun 9, 2017

Copy link
Copy Markdown
MemberAuthor

The 'Required.' in field descriptions is our indication of a required field.

Well, yes, obviously. ;)

It should not be capitalized.

Happy to revert, but in what sense does Required. not "mean that the definition is an absolute requirement of the specification." ?

I specifically wanted to avoid increasing ambiguity by saying REQUIRED was only a key word when capitalised, then having it not capitalised where it does in fact mandate behaviour.

We could add extra wording e.g. as suggested by @ePaul .

@webron

Copy link
Copy Markdown
Member

Perhaps I shouldn't have jumped before reading the entire PR and conversation - I just didn't want extra work to be put into it for nothing. Unfortunately, I can't review it all right now.

@RobDolinMS

Copy link
Copy Markdown
Contributor

#TDC @RobDolinMS and @fehguy are both thumbs-up.

@RobDolinMS
RobDolinMS merged commit 5471a18 into OAI:OpenAPI.nextJun 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MikeRalphson@RobDolinMS@webron@darrelmiller@ePaul
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Captitalise key words, update guidance to rfc8174 by MikeRalphson · Pull Request #1149 · OAI/OpenAPI-Specification · GitHub
Skip to content

Captitalise key words, update guidance to rfc8174 - #1149

Merged
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords
Jun 9, 2017
Merged

Captitalise key words, update guidance to rfc8174#1149
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords

Conversation

@MikeRalphson

Copy link
Copy Markdown
Member

More nit-picking / doc cleanup ;)

  • Update the guidance text on key words to clarify only uppercase instances are to be interpreted as key words - this helps with ambguity over 'may' meaning 'might' and 'MAY' meaning 'it is permitted', 'not all ... must be' etc.
  • Update guidance to reference RFC8174
  • Uppercase key words where apparently needed
  • Make use of Required. / Required. / Required consistent => REQUIRED
  • Change one * to \* to fix an ambiguity over italic text and aid editing the spec in Vim's markdown syntax highlighting mode (other editors are probably available)
  • Erroneous whitespace has been removed only where it was on a line already being modified.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of linking the .txt version, I would recommend the HTML one.

@ePaulePaulJun 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template in RFC8174 says to actually mention both RFCs (and the BCP number):

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I hesitated on that and went with brevity over having the three links, but can amend.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the word "REQUIRED" here actually conforms to RFC 2119, as it doesn't prescribe any behavior.
Maybe the initial paragraph referencing the RFCs and listing the keywords, or the first paragraph under "Schema" should get an additional sentence like this:

A sentence consisting of just the word REQUIRED in a field definition means that including the field is REQUIRED when sending the containing object.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to RFC8174, should the full language be:

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're editing this line, would you want to also make it one sentence per line?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think elsewhere table cells are always written on one line?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table cells have to be one line. At least in the past that was the case.

@RobDolinMS

Copy link
Copy Markdown
Contributor

Thank you @MikeRalphson for this PR. I'm a fan of the clear use of CAPITALIZATION to indicate BCP14 words. I added two suggestions on specific lines.

@webron

Copy link
Copy Markdown
Member

I've yet had a chance to review the PR but something did catch my eye. The 'Required.' in field descriptions is our indication of a required field. It should not be capitalized.

@MikeRalphson

MikeRalphson commented Jun 9, 2017

Copy link
Copy Markdown
MemberAuthor

The 'Required.' in field descriptions is our indication of a required field.

Well, yes, obviously. ;)

It should not be capitalized.

Happy to revert, but in what sense does Required. not "mean that the definition is an absolute requirement of the specification." ?

I specifically wanted to avoid increasing ambiguity by saying REQUIRED was only a key word when capitalised, then having it not capitalised where it does in fact mandate behaviour.

We could add extra wording e.g. as suggested by @ePaul .

@webron

Copy link
Copy Markdown
Member

Perhaps I shouldn't have jumped before reading the entire PR and conversation - I just didn't want extra work to be put into it for nothing. Unfortunately, I can't review it all right now.

@RobDolinMS

Copy link
Copy Markdown
Contributor

#TDC @RobDolinMS and @fehguy are both thumbs-up.

@RobDolinMS
RobDolinMS merged commit 5471a18 into OAI:OpenAPI.nextJun 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MikeRalphson@RobDolinMS@webron@darrelmiller@ePaul
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Captitalise key words, update guidance to rfc8174 by MikeRalphson · Pull Request #1149 · OAI/OpenAPI-Specification · GitHub
Skip to content

Captitalise key words, update guidance to rfc8174 - #1149

Merged
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords
Jun 9, 2017
Merged

Captitalise key words, update guidance to rfc8174#1149
RobDolinMS merged 1 commit into
OAI:OpenAPI.nextfrom
MikeRalphson:recwords

Conversation

@MikeRalphson

Copy link
Copy Markdown
Member

More nit-picking / doc cleanup ;)

  • Update the guidance text on key words to clarify only uppercase instances are to be interpreted as key words - this helps with ambguity over 'may' meaning 'might' and 'MAY' meaning 'it is permitted', 'not all ... must be' etc.
  • Update guidance to reference RFC8174
  • Uppercase key words where apparently needed
  • Make use of Required. / Required. / Required consistent => REQUIRED
  • Change one * to \* to fix an ambiguity over italic text and aid editing the spec in Vim's markdown syntax highlighting mode (other editors are probably available)
  • Erroneous whitespace has been removed only where it was on a line already being modified.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of linking the .txt version, I would recommend the HTML one.

@ePaulePaulJun 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template in RFC8174 says to actually mention both RFCs (and the BCP number):

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I hesitated on that and went with brevity over having the three links, but can amend.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the word "REQUIRED" here actually conforms to RFC 2119, as it doesn't prescribe any behavior.
Maybe the initial paragraph referencing the RFCs and listing the keywords, or the first paragraph under "Schema" should get an additional sentence like this:

A sentence consisting of just the word REQUIRED in a field definition means that including the field is REQUIRED when sending the containing object.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to RFC8174, should the full language be:

 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
"MAY", and "OPTIONAL" in this document are to be interpreted as
described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
appear in all capitals, as shown here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Comment threadversions/3.0.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're editing this line, would you want to also make it one sentence per line?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think elsewhere table cells are always written on one line?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table cells have to be one line. At least in the past that was the case.

@RobDolinMS

Copy link
Copy Markdown
Contributor

Thank you @MikeRalphson for this PR. I'm a fan of the clear use of CAPITALIZATION to indicate BCP14 words. I added two suggestions on specific lines.

@webron

Copy link
Copy Markdown
Member

I've yet had a chance to review the PR but something did catch my eye. The 'Required.' in field descriptions is our indication of a required field. It should not be capitalized.

@MikeRalphson

MikeRalphson commented Jun 9, 2017

Copy link
Copy Markdown
MemberAuthor

The 'Required.' in field descriptions is our indication of a required field.

Well, yes, obviously. ;)

It should not be capitalized.

Happy to revert, but in what sense does Required. not "mean that the definition is an absolute requirement of the specification." ?

I specifically wanted to avoid increasing ambiguity by saying REQUIRED was only a key word when capitalised, then having it not capitalised where it does in fact mandate behaviour.

We could add extra wording e.g. as suggested by @ePaul .

@webron

Copy link
Copy Markdown
Member

Perhaps I shouldn't have jumped before reading the entire PR and conversation - I just didn't want extra work to be put into it for nothing. Unfortunately, I can't review it all right now.

@RobDolinMS

Copy link
Copy Markdown
Contributor

#TDC @RobDolinMS and @fehguy are both thumbs-up.

@RobDolinMS
RobDolinMS merged commit 5471a18 into OAI:OpenAPI.nextJun 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MikeRalphson@RobDolinMS@webron@darrelmiller@ePaul