Uh oh!
There was an error while loading. Please reload this page.
add description to all schemas - #2802
Conversation
jdesrosiers
left a comment
There was a problem hiding this comment.
I think this is a great idea. I have a couple suggestions that I hope will make some of the descriptions even more helpful.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
karenetheridge
commented
Dec 2, 2021
ok, this might be a bit better now. |
d931c05 to
8ab4f97Compare
jdesrosiers
left a comment
There was a problem hiding this comment.
Looks good, but one description is still not quite right.
| @@ -1,3 +1,4 @@ | |||
| description: A dialect to use for schemas within OpenAPI documents | |||
There was a problem hiding this comment.
This isn't a dialect schema. It describes an OpenAPI document where the schemas all use the OpenAPI Schema dialect.
8ab4f97 to
5f8dff8Compare
jdesrosiers
left a comment
There was a problem hiding this comment.
One of the descriptions is not quite right. In case it's still unclear what that schema is for, there's a better description here, https://json-schema.org/blog/posts/validating-openapi-and-json-schema
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
175e688 to
6259423Comparekarenetheridge
commented
Feb 11, 2022
done. |
jdesrosiers
left a comment
There was a problem hiding this comment.
The JSON versions need to be updated too.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
834722a to
6f1c55bComparein v3.1 the number of schemas increased considerably, which can be a bit confusing.
6f1c55b to
12bc151Comparewebron
commented
Feb 24, 2022
Thanks for all the effort, @karenetheridge, and @jdesrosiers for the additional reviews! |
in v3.1 the number of schemas increased considerably, which can be a bit confusing.