Uh oh!
There was an error while loading. Please reload this page.
whitespace and quoting fixes in json and yaml examples (v3.2.0) - #3466
Merged
earth2marsh merged 1 commit intoFeb 22, 2024
Merged
Conversation
darrelmiller
approved these changes
Dec 7, 2023
karenetheridgeforce-pushed
the
ether/whitespace-examples-v3.2.0
branch
from
December 27, 2023 19:46
f75f3bd to
ab71df8Comparekarenetheridge
commented
Dec 27, 2023
MemberAuthor
rebased. |
karenetheridgeforce-pushed
the
ether/whitespace-examples-v3.2.0
branch
from
February 5, 2024 06:20
ab71df8 to
cad9c6dComparehandrews
commented
Feb 7, 2024
Member
I re-ran the failed check using the environment from main (see #3554) and it passed. This is safe to merge. |
mikekistler
commented
Feb 15, 2024
Question on this: Can we establish our conventions for whitespace and quoting and then enforce them in the PR pipeline? I'm just thinking that we don't want to have to fix this again in 6 months. |
lornajane
commented
Feb 15, 2024
Contributor
Yes, let's open an issue for it. I have this on a bunch of other repos and can add it here too |
karenetheridgeforce-pushed
the
ether/whitespace-examples-v3.2.0
branch
from
February 20, 2024 01:13
cad9c6d to
856c742Comparekarenetheridge
commented
Feb 20, 2024
MemberAuthor
rebased! |
karenetheridgeforce-pushed
the
ether/whitespace-examples-v3.2.0
branch
from
February 20, 2024 01:24
856c742 to
abaa97dComparelornajane
commented
Feb 20, 2024
Contributor
I opened #3596 to make this repeatable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same as #3465