Uh oh!
There was an error while loading. Please reload this page.
adds missing package lock for reproductible CI - #3564
Conversation
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
commented
Feb 9, 2024
Note: the schema test will fail until we merge to main since there currently isn't any package-lock.json on main |
lornajane
commented
Feb 9, 2024
How does this change affect people running the checks locally? |
baywet
commented
Feb 9, 2024
when you install locally, you'll get the same exact versions that were installed when this file was setup (or whenever a dependabot update was merged). It improves reproducibility |
baywet
commented
Feb 9, 2024
on the first pull after this gets merged however, you might have git complaining that you already have a package-lock.json if you've already ran |
handrews
commented
Feb 13, 2024
After some discussion last week, this sort of limited-impact change (most of our checks are failing right now anyway) can be merged with one approval, so I'm doing that. |
fixes#3556