Skip to content

adds missing package lock for reproductible CI - #3564

Merged
handrews merged 3 commits into
OAI:mainfrom
baywet:bugfix/package-lock
Feb 13, 2024
Merged

adds missing package lock for reproductible CI#3564
handrews merged 3 commits into
OAI:mainfrom
baywet:bugfix/package-lock

Conversation

@baywet

Copy link
Copy Markdown
Member

fixes#3556

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
baywet requested review from a team as code ownersFebruary 9, 2024 13:01
@baywet

Copy link
Copy Markdown
MemberAuthor

Note: the schema test will fail until we merge to main since there currently isn't any package-lock.json on main

@lornajane

Copy link
Copy Markdown
Contributor

How does this change affect people running the checks locally?

@baywet

Copy link
Copy Markdown
MemberAuthor

when you install locally, you'll get the same exact versions that were installed when this file was setup (or whenever a dependabot update was merged). It improves reproducibility

@baywet

Copy link
Copy Markdown
MemberAuthor

on the first pull after this gets merged however, you might have git complaining that you already have a package-lock.json if you've already ran npm i. Just delete it. That's a one time problem affecting people who installed before this PR.
People familiar with git and/or npm should be able to resolve that on their own without requiring assistance.

@handrewshandrews left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You'll need to make PRs copying the schema-tests.yaml workflow out to the v3.0.4-dev, v3.1.1-dev, and v3.2.0-dev (like PRs #3560, #3561, and #3562).

@handrews

Copy link
Copy Markdown
Member

After some discussion last week, this sort of limited-impact change (most of our checks are failing right now anyway) can be merged with one approval, so I'm doing that.

@handrews
handrews merged commit 617f3d9 into OAI:mainFeb 13, 2024
@baywet
baywet deleted the bugfix/package-lock branch August 21, 2024 13:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

this repository should contain a package-lock.json

3 participants

@baywet@lornajane@handrews