Skip to content

Clarify openIdConnectUrl #3630 - #3718

Merged
lornajane merged 3 commits into
OAI:v3.1.1-devfrom
m-mohr:patch-2
May 1, 2024
Merged

Clarify openIdConnectUrl #3630#3718
lornajane merged 3 commits into
OAI:v3.1.1-devfrom
m-mohr:patch-2

Conversation

@m-mohr

@m-mohrm-mohr commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

Clarification according to openIdConnectUrl as discussed in #3630

@handrewshandrews mentioned this pull request Apr 19, 2024
Closed
@handrewshandrews added this to the v3.1.1 milestone Apr 20, 2024
@handrewshandrews added the clarification requests to clarify, but not change, part of the spec label Apr 22, 2024
@AxelNennker

AxelNennker commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

I think this PR improves the spec. I approve - modulo which version this should go into. Personally I would backport this clarification to when openIdConnectUrl was introduced.

lornajane
lornajane requested changes Apr 25, 2024
View reviewed changes
Comment threadversions/3.1.1.md Outdated
@m-mohr
m-mohr requested a review from lornajaneApril 25, 2024 19:54
@ralfhandl

ralfhandl commented Apr 26, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

@lornajane The text cited from the referenced spec was removed, instead "well-known" is now part of the link text.

I think that matches the spirit of the requested change, please confirm.

AxelNennker
AxelNennker suggested changes Apr 26, 2024
View reviewed changes

@AxelNennkerAxelNennker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text should be like the oauth2MetadataUrl text in version 3.2

Comment threadversions/3.1.1.md Outdated
lornajane
lornajane approved these changes May 1, 2024
View reviewed changes

@lornajanelornajane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good clarification for this existing field, thank you.

@lornajane
lornajane merged commit 88b199d into OAI:v3.1.1-devMay 1, 2024
@m-mohr
m-mohr deleted the patch-2 branch May 1, 2024 08:37
@m-mohr

m-mohr commented May 1, 2024

Copy link
Copy Markdown
ContributorAuthor

How is this going to be made available in 3.2.0?

@handrews

handrews commented May 1, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@m-mohr someone needs to copy the fix over to the versions/3.2.0.md file on the v3.2.0-dev branch. If you have time to do it, that would be most appreciated! If not, we'll audit the branches at some point to reconcile. (starting with 3.2, we will be moving to a more normal use of git branches of a single spec file).

This was referenced Jun 3, 2024
Closed
Closed
Merged
miqui added a commit that referenced this pull request Jun 6, 2024
@miqui
Merge pull request#3882from handrews/m-mohr-fix-openid-disc
75826ef
OpenID Connect Discovery URL fix (3.0.4 port of #3718)
@handrewshandrews mentioned this pull request Jun 8, 2024
Merged
miqui added a commit that referenced this pull request Jun 19, 2024
@miqui
Merge pull request#3891from handrews/oidc-320
8933990
OIDC fixes (3.2.0 port of #3607, #3718)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lornajanelornajanelornajane approved these changes
@ralfhandlralfhandlralfhandl approved these changes
@handrewshandrewshandrews approved these changes
+1 more reviewer
@AxelNennkerAxelNennkerAxelNennker requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

clarificationrequests to clarify, but not change, part of the specsecurity

Projects

None yet

Milestone

v3.1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@m-mohr@AxelNennker@ralfhandl@handrews@lornajane