Skip to content

fix style=form examples (3.0.4) - #3742

Merged
handrews merged 2 commits into
OAI:v3.0.4-devfrom
karenetheridge:v3.0.4-dev
May 3, 2024
Merged

fix style=form examples (3.0.4)#3742
handrews merged 2 commits into
OAI:v3.0.4-devfrom
karenetheridge:v3.0.4-dev

Conversation

@karenetheridge

@karenetheridgekarenetheridge commented Apr 25, 2024

Copy link
Copy Markdown
Member

These should have the parameter name in the resulting string (see issue #3737).

@karenetheridge
fix style=form examples
11ba729
These should have the parameter name in the resulting string (see issue OAI#3737).
@karenetheridgekarenetheridge changed the title fix style=form examplesfix style=form examples (3.0.4)Apr 25, 2024
@karenetheridge

karenetheridge commented Apr 25, 2024

Copy link
Copy Markdown
MemberAuthor

This will need me to resolve conflicts resolved after merging #3744.

@handrewshandrews added the examples requests for more or better examples in the specification label Apr 25, 2024
@handrewshandrews added this to the v3.0.4 milestone Apr 25, 2024
ralfhandl
ralfhandl previously approved these changes Apr 26, 2024
View reviewed changes
handrews
handrews previously approved these changes May 1, 2024
View reviewed changes
@handrewshandrews mentioned this pull request May 2, 2024
Closed
mikekistler
mikekistler reviewed May 2, 2024
View reviewed changes

@mikekistlermikekistler left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other fixes needed here?

Comment threadversions/3.0.4.md Outdated
mikekistler
mikekistler approved these changes May 2, 2024
View reviewed changes

@mikekistlermikekistler left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl

ralfhandl commented May 2, 2024

Copy link
Copy Markdown
Contributor

@karenetheridge please resolve conflict

@handrews
handrews dismissed stale reviews from ralfhandl and themself via 528c3c7May 3, 2024 18:57
@handrews

handrews commented May 3, 2024

Copy link
Copy Markdown
Member

@ralfhandl@mikekistler@miqui@karenetheridge I resolved the conflicts but that invalidated the approval - can someone re-approve and merge?

@handrews

handrews commented May 3, 2024

Copy link
Copy Markdown
Member

Oh weird, it let me approve it? We might want to look into the permissions here, but for now I will merge since there were already 2 TSC approvals and the 3.1.1 and 3.2.0 versions were merged.

@handrews
handrews merged commit 06a36ba into OAI:v3.0.4-devMay 3, 2024
@ralfhandl

ralfhandl commented May 6, 2024

Copy link
Copy Markdown
Contributor

@handrews you are not the PR author, so you can approve.
We technically require only one approval for merging, and you are a maintainer, so you can approve and then directly merge as long as no other maintainer has requested changes.

"Two TSC approvals" is currently only a convention, not technically enforced.

@karenetheridge
karenetheridge deleted the v3.0.4-dev branch May 7, 2024 16:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralfhandlralfhandlralfhandl left review comments
@handrewshandrewshandrews approved these changes
@mikekistlermikekistlermikekistler approved these changes

Assignees

No one assigned

Labels

examplesrequests for more or better examples in the specification

Projects

None yet

Milestone

v3.0.4

Development

Successfully merging this pull request may close these issues.

4 participants

@karenetheridge@ralfhandl@handrews@mikekistler