Skip to content

Use pinned version of MAINTAINERS.md per spec version - #3782

Merged
lornajane merged 7 commits into
mainfrom
fix/maintainers-per-spec-version
May 14, 2024
Merged

Use pinned version of MAINTAINERS.md per spec version#3782
lornajane merged 7 commits into
mainfrom
fix/maintainers-per-spec-version

Conversation

@ralfhandl

@ralfhandlralfhandl commented May 6, 2024

Copy link
Copy Markdown
Contributor

Fixes#3693

Quick fix for respec build script:

  • use pinned version of MAINTAINERS.md for all 3.x specs

TODO:

  • use nearest version of MAINTAINERS.md for each 3.x spec
  • create static content for missing version of MAINTAINERS.md for 2.0 spec

@ralfhandl
ralfhandl marked this pull request as ready for review May 6, 2024 11:23
@ralfhandl
ralfhandl requested review from a team as code ownersMay 6, 2024 11:23
@ralfhandlralfhandl changed the title Quick-fix: use same pinned version of MAINTAINERS.md for all 3.x specsUse pinned versions of MAINTAINERS.md for all specsMay 6, 2024
@ralfhandlralfhandl changed the title Use pinned versions of MAINTAINERS.md for all specsUse pinned version of MAINTAINERS.md per spec versionMay 6, 2024
Comment on lines +15 to +16
* Jeremy Whitlock [@whitlockjc](https://github.com/whitlockjc)
* Marsh Gardiner [@earth2marsh](https://github.com/earth2marsh)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitlockjc@earth2marsh please confirm, my OpenAPI history knowledge is spotty.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webron remains an active maintainer, too! otherwise lgtm (assuming I understood the question)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @webron is an active maintainer in all versions of MAINTAINERS.md.

The question is whether I listed all active editors of version 2.0, and whether there were any changes between publication of 2.0 and 3.0.0.

Ignore additional lists "in the middle"

@lornajanelornajane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diving into this @ralfhandl (I think the historical data is correct)

@lornajane
lornajane merged commit 1be009f into mainMay 14, 2024
@lornajane
lornajane deleted the fix/maintainers-per-spec-version branch May 14, 2024 08:41
@handrewshandrews mentioned this pull request May 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReSpec HTML generation needs to use correct revision of MAINTAINERS.md

4 participants

@ralfhandl@earth2marsh@lornajane@miqui