Uh oh!
There was an error while loading. Please reload this page.
Allow URI-references for Security Requirements (3.2.0) - #3821
Closed
handrews wants to merge 1 commit into
Closed
Conversation
This allows Security Requirement Objects to reference Security Scheme Objects by URI instead of implicit component name. Without this ability, it is difficult to share Security Schemes in a way that is consistent with re-usable component documents. This approach provides parity with how the Discriminator Object's `mapping` field works.
Uh oh!
There was an error while loading. Please reload this page.
ralfhandl
self-requested a review
May 23, 2024 15:05
ralfhandl
approved these changes
May 23, 2024
miqui
approved these changes
Aug 25, 2024
handrews
commented
Aug 28, 2024
MemberAuthor
@miqui@ralfhandl I think I'm actually going to take this down and write a proposal- when I submitted this I did not realize that we needed a similar solution for tags, and I need to think it through a bit. I can think of two ways to handle it and I'm not suire which is better. |
ralfhandl
commented
Aug 28, 2024
Contributor
Looking forward to the next PR 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is a draft because I was going to make it a proposal, but its much shorter to just show the PR than explain it some other way. See PR #3823 for more context.
Fixes:
securitySchemaobject ? #1972This allows Security Requirement Objects to reference Security Scheme Objects by URI instead of implicit component name. Without this ability, it is difficult to share Security Schemes in a way that is consistent with re-usable component documents.
This approach provides parity with how the Discriminator Object's
mappingfield works.