Uh oh!
There was an error while loading. Please reload this page.
Preserve rfc section links - #3956
Merged
Merged
Conversation
handrews
approved these changes
Jul 25, 2024
handrews
left a comment
Member
There was a problem hiding this comment.
Minor comments, but I'm fine with this going in.
Comment on lines
+277
to
+282
| //TODO: unconventional references to RFCs in 3.0.4 and 3.1.1, for example | ||
| // [RFC3986 §5.1.2 – 5.1.4](https://tools.ietf.org/html/rfc3986#section-5.1.2) | ||
| // RFC6570 [mentions](https://www.rfc-editor.org/rfc/rfc6570.html#section-2.4.2) | ||
| // [are not](https://datatracker.ietf.org/doc/html/rfc3986#appendix-A) | ||
| // [special behavior](https://www.rfc-editor.org/rfc/rfc1866#section-8.2.1) | ||
| // [RFC6570 considers to be _undefined_](https://datatracker.ietf.org/doc/html/rfc6570#section-2.3) |
Member
There was a problem hiding this comment.
I'm entirely fine with making these more normal rather than working around them in the build script.
Comment on lines
+292
to
+293
| //TODO: non-link mentions of RFCs in 3.0.4 and 3.1.1, for example | ||
| // RFC3986's definition of [reserved](https://datatracker.ietf.org/doc/html/rfc3986#section-2.2) |
Member
There was a problem hiding this comment.
Also fine with these being made more typical.
Comment on lines
-311
to
+329
| if (Math.abs(delta)>1) console.warn(delta,line); | ||
| // if (Math.abs(delta)>1) console.warn(delta,line); |
Member
There was a problem hiding this comment.
Any particular reason to keep this line as a comment instead of delete?
ContributorAuthor
There was a problem hiding this comment.
Will remove them in a future PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#3863
See for example