Uh oh!
There was an error while loading. Please reload this page.
Build script: no local biblio, use only Specref ids - #3992
Merged
Conversation
handrews
reviewed
Aug 5, 2024
Uh oh!
There was an error while loading. Please reload this page.
lornajane
commented
Aug 8, 2024
Contributor
We agreed that we need a bit more context in the code comment about why this section is special. |
* better green for headlines * consistent headline styles * JSON Reference as normative reference
ralfhandl
commented
Aug 8, 2024
Comment on lines
+110
to
+112
| preface += '#title { color: #578000; } #subtitle { color: #578000; }'; | ||
| preface += '.dt-published { color: #578000; } .dt-published::before { content: "Published "; }'; | ||
| preface += 'h1,h2,h3,h4,h5,h6 { color: #578000; font-weight: normal; font-style: normal; }'; |
ContributorAuthor
There was a problem hiding this comment.
That's the new green: all headlines now use the same color, font-weight, and font-style and differ only in font-size.
ralfhandl
commented
Aug 8, 2024
Comment on lines
-265
to
-304
| if (!inCodeBlock && line.startsWith('#')) { | ||
| let indent = 0; | ||
| while (line[indent] === '#') indent++; | ||
| let originalIndent = indent; | ||
| let prevIndent = indents[indents.length-1]; // peek | ||
| let delta = indent-prevIndent; | ||
| if (!argv.respec) { | ||
| if (delta===0) indent = lastIndent | ||
| else if (delta<0) indent = lastIndent-1 | ||
| else if (delta>0) indent = lastIndent+1; | ||
| } | ||
| if (indent < 0) { | ||
| indent = 1; | ||
| } | ||
| if (argv.respec && (indent > 1)) { | ||
| indent--; | ||
| } | ||
| let newIndent = indent; | ||
| if (!argv.respec && (indent <= 2) && bsFix) { | ||
| newIndent++; | ||
| } | ||
| let title = line.split('# ')[1]; | ||
| if (inDefs) title = '<dfn>'+title+'</dfn>'; | ||
| line = ('#'.repeat(newIndent)+' '+title); | ||
| if (delta>0) indents.push(originalIndent); | ||
| if (delta<0) { | ||
| let d = Math.abs(delta); | ||
| while (d>0) { | ||
| indents.pop(); | ||
| d--; | ||
| } | ||
| } | ||
| lastIndent = indent; | ||
| } | ||
ContributorAuthor
There was a problem hiding this comment.
Moved unchanged down next to the other code block for headline processing
ralfhandl
commented
Aug 8, 2024
ContributorAuthor
@handrews Please tell me if I need to add comments or explain more |
This was referenced Aug 8, 2024
miqui
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
localBiblio## Version x.y.z- no longer expect#### Version x.y.zNote: this needs to be merged before we can publish the cleaned-up 3.0.4.md and 3.1.1.md
Example output: