Uh oh!
There was an error while loading. Please reload this page.
3.0.4: tables cleanup & markdownlint - #4040
Conversation
mikekistler
left a comment
There was a problem hiding this comment.
Looks good. 👍
Left a comment to remove some unnecessary leading white space.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
ralfhandl
commented
Aug 20, 2024
Update after #4027 is merged, check out .markdownlint.yaml from |
lornajane
commented
Aug 22, 2024
I expected to see the action running in this pull request, should it? |
ralfhandl
commented
Aug 22, 2024
Probably the merge conflict prevents the script from running. |
ralfhandl
commented
Aug 26, 2024
@handrews Added
|
Uh oh!
There was an error while loading. Please reload this page.
I can't say I'm at all happy with Prettier's markdown behavior, but this is better than what it was doing to tables before. This double-change of every single table line is going to be such a pain for searching change history :-( Although if we do a lot of rearranging for 3.2 I guess it won't matter anyway. Plus searching change history is already incredibly hard in this repo. |
ralfhandl
commented
Aug 27, 2024
Me neither, but it does format the code blocks correctly.
Thanks. |
mikekistler
left a comment
There was a problem hiding this comment.
Looks good. 👍
I was concerned that the prettier extension in VSCode (my preferred editing environment) might reflow the tables if I made any change to the file, but I tested this and found that not to be the case.
ralfhandl
commented
Aug 27, 2024
My VS Code does if I explicitly format the file with the prettier extension enabled, or if I have "format on save" turned on and save the file. Which is why I have both the extension disabled for this workspace and "format on save" turned off in the workspace settings 😎 |
handrews
commented
Aug 27, 2024
This is why I use vi 😛 (ok technically vim, but that's my only concession to modernity!) |
ralfhandl
commented
Aug 28, 2024
vi was my preferred tool for editing the makefile for Emacs 😎 |
ralfhandl
commented
Aug 29, 2024
Merging as @mikekistler has already approved half a dozen times 😎 |
mainbranchformat-markdownto conveniently reformat markdown after changesPart of