Skip to content

main: schema test coverage - #4173

Merged
handrews merged 8 commits into
OAI:mainfrom
ralfhandl:main-schema-test-coverage
Nov 21, 2024
Merged

main: schema test coverage#4173
handrews merged 8 commits into
OAI:mainfrom
ralfhandl:main-schema-test-coverage

Conversation

@ralfhandl

@ralfhandlralfhandl commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

Thanks to @jdesrosiers we can now measure the coverage of our schema tests.

Bad news: it is pretty low right now:

  • 3.0: Covered: 258 of 531 (48%)
  • 3.1: Covered: 220 of 608 (36%)

Shamelessly copied from

@ralfhandl
ralfhandl marked this pull request as draft November 6, 2024 14:52
@jeremyfiel

jeremyfiel commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

I can help write some of these as I get time.. do you prefer a lot of smaller tests of individual items or combining many different ones into a large OAS file?

i have one available with up to 85+% coverage

@ralfhandl

Copy link
Copy Markdown
ContributorAuthor

For fail test cases I prefer minimalistic files that contain exactly one error.

For pass test cases "maximum" examples covering optional stuff in addition the required minimum are perfectly fine.

@ralfhandl
ralfhandl marked this pull request as ready for review November 12, 2024 10:31
@ralfhandlralfhandl added Schema changes related to the schema(s) Housekeeping labels Nov 13, 2024
@ralfhandl
ralfhandl changed the base branch from main to devNovember 13, 2024 18:58
@ralfhandl
ralfhandl changed the base branch from dev to mainNovember 13, 2024 18:59
@handrews
handrews merged commit 50103d8 into OAI:mainNov 21, 2024
@ralfhandl
ralfhandl deleted the main-schema-test-coverage branch November 21, 2024 12:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HousekeepingSchemachanges related to the schema(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ralfhandl@jeremyfiel@handrews