Uh oh!
There was an error while loading. Please reload this page.
Editorial change: Include Header Object into 'Working With Examples' section - #4265
Merged
handrews merged 6 commits intoDec 19, 2024
Conversation
ralfhandl
requested changes
Dec 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
char0n
commented
Dec 18, 2024
ContributorAuthor
@ralfhandl thanks for catching all inconsistencies! |
handrews
previously approved these changes
Dec 18, 2024
mikekistler
previously approved these changes
Dec 18, 2024
mikekistler
left a comment
There was a problem hiding this comment.
Looks good. 👍
I left one question/suggestion that you may want to consider.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
ralfhandl
approved these changes
Dec 19, 2024
handrews
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When studying changes of OpenAPI 3.0.4 (from the OpenAPI 3.0.3), I've noticed a section Working with examples. Everything that is written there does apply to
Header Object. In other section when something apply toHeader Objectit is enumerated explicitly. But inWorking with examplessection, the header is missing. IMHO it's an unintended omission, and this PR is trying to remedy it.Appendix B.
Appendix C.