Skip to content

dev: schemas live in src folder - #4361

Merged
lornajane merged 15 commits into
OAI:devfrom
ralfhandl:dev-schemas-live-in-src
Feb 20, 2025
Merged

dev: schemas live in src folder#4361
lornajane merged 15 commits into
OAI:devfrom
ralfhandl:dev-schemas-live-in-src

Conversation

@ralfhandl

@ralfhandlralfhandl commented Feb 13, 2025•
edited by lornajane
Loading

Copy link
Copy Markdown
Contributor

Part of #4356

  • remove schemas folder - the work-in-progress schemas are in the src/schemas/validation folder
  • only test the work-in-progress schema sources
  • only measure test coverage for work-in-progress schema sources
  • create deployable schema files from schema sources in the src/schemas/validation
  • template workflow for schema publishing from vX.Y-dev branches

Tick one of the following options:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@ralfhandl
ralfhandl requested review from a team as code ownersFebruary 13, 2025 22:52
@ralfhandlralfhandl added Schema changes related to the schema(s) Housekeeping labels Feb 13, 2025
@ralfhandl
ralfhandl changed the base branch from main to devFebruary 13, 2025 22:57
@ralfhandlralfhandl mentioned this pull request Feb 13, 2025
Closed
@ralfhandlralfhandl mentioned this pull request Feb 13, 2025
Closed
11 tasks
@ralfhandlralfhandl mentioned this pull request Feb 6, 2025
Closed
5 tasks
This was linked to issues Feb 14, 2025
Create dev build infrastructure #4223
Closed
Clean up /schemas on main branch #4356
Closed
duncanbeevers
duncanbeevers approved these changes Feb 15, 2025
View reviewed changes
Comment threadsrc/schemas/validation/README.md Outdated
Comment threadscripts/schema-publish.sh
Comment threadpackage.json Outdated
Comment threadscripts/schema-publish.sh Outdated
@ralfhandlralfhandl mentioned this pull request Feb 17, 2025
Merged
5 tasks
ralfhandl
ralfhandl commented Feb 18, 2025
View reviewed changes
Comment threadsrc/schemas/validation/README.md Outdated
lornajane
lornajane reviewed Feb 20, 2025
View reviewed changes
Comment thread.github/workflows/schema-publish.yaml Outdated
push:
branches:
- main
- vX.Y-dev

@lornajanelornajaneFeb 20, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a list of the actual dev branch names here

lornajane
lornajane reviewed Feb 20, 2025
View reviewed changes
Comment threadsrc/schemas/validation/README.md Outdated
@@ -39,14 +39,14 @@ Schemas to perform additional optional validation are [under consideration](http

Improvements can be submitted by opening a PR against the `main` branch.

@lornajanelornajaneFeb 20, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the main branch! A dev branch, I think we mean.

lornajane
lornajane reviewed Feb 20, 2025
View reviewed changes
Comment threadsrc/schemas/validation/README.md
@lornajane
lornajane merged commit 92e5fc9 into OAI:devFeb 20, 2025
@ralfhandl
ralfhandl deleted the dev-schemas-live-in-src branch February 20, 2025 17:41
This was referenced Feb 20, 2025
Closed
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lornajanelornajanelornajane approved these changes
+1 more reviewer
@duncanbeeversduncanbeeversduncanbeevers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

HousekeepingSchemachanges related to the schema(s)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up /schemas on main branch Create dev build infrastructure

3 participants

@ralfhandl@duncanbeevers@lornajane