Uh oh!
There was an error while loading. Please reload this page.
v3.2: Allow allowReserved everywhere - #4593
Merged
Merged
Conversation
The restriction on `allowReserved` make some useful configurations impossible, and do not actually prevent pathological scenarios like path parameter values containing `/`, from occurring. Such pathological scenarios are already possible by using `content` instead of `style`/`explode`/`allowReserved`. Lifting the restriction also makes the handling of this field more consistent.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
ralfhandl
approved these changes
May 18, 2025
karenetheridge
commented
May 22, 2025
Member
I changed the ticky box on required schema changes, given that there are some in this PR. |
lornajane
approved these changes
May 22, 2025
lornajane
left a comment
Contributor
There was a problem hiding this comment.
No objections, kind of hope that not many people need this though
lornajane
commented
May 22, 2025
Contributor
Leaving open for anyone with more concerns to chime in before we merge. |
miqui
commented
May 24, 2025
Contributor
Looks good to me. |
lornajane
commented
May 24, 2025
Contributor
That's a strong triple-approval! I'm merging. |
1 task
lornajane added a commit
that referenced
this pull request
Jun 12, 2025
v3.2: Allow `allowReserved` in the Header Object (left out of PR #4593 by mistake)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
;in path parameters outside ofmatrixexpansion)The restriction on
allowReservedmake some useful configurations impossible, and do not actually prevent pathological scenarios like path parameter values containing/, from occurring. Such pathological scenarios are already possible by usingcontentinstead ofstyle/explode/allowReserved.Lifting the restriction also makes the handling of this field more consistent, as it is no longer necessary to keep track of the destination.