Skip to content

v3.2: Schema updates for #4339 - #4805

Merged
handrews merged 2 commits into
v3.2-devfrom
mdk/4804-optional-discriminator-schema
Jul 22, 2025
Merged

v3.2: Schema updates for #4339#4805
handrews merged 2 commits into
v3.2-devfrom
mdk/4804-optional-discriminator-schema

Conversation

@mikekistler

@mikekistlermikekistler commented Jul 20, 2025

Copy link
Copy Markdown

My attempt at schema updates for #4339.

Fixes#4804

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@mikekistler
mikekistler requested review from a team as code ownersJuly 20, 2025 13:38
ralfhandl
ralfhandl requested changes Jul 20, 2025
View reviewed changes

@ralfhandlralfhandl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaultMapping has type string according to the spec text

Comment threadsrc/schemas/validation/meta.yaml Outdated
Comment threadtests/schema/pass/mega.yaml Outdated
@handrewshandrews changed the title Schema updates for #4339v3.2: Schema updates for #4339Jul 20, 2025
mikekistler
mikekistler commented Jul 20, 2025
View reviewed changes
Comment threadtests/schema/pass/mega.yaml Outdated
Mike Kistler@ralfhandl
Apply suggestions from PR review
3a78835
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
@ralfhandl
ralfhandl requested a review from a teamJuly 20, 2025 18:43
@handrews
handrews merged commit 25fe305 into v3.2-devJul 22, 2025
3 checks passed
@handrews
handrews deleted the mdk/4804-optional-discriminator-schema branch July 22, 2025 19:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralfhandlralfhandlralfhandl approved these changes
@handrewshandrewshandrews approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikekistler@ralfhandl@handrews