Skip to content

v3.2: Update Set-Cookie example for recent changes - #4903

Merged
ralfhandl merged 3 commits into
OAI:v3.2-devfrom
handrews:set-cookie-example
Aug 25, 2025
Merged

v3.2: Update Set-Cookie example for recent changes#4903
ralfhandl merged 3 commits into
OAI:v3.2-devfrom
handrews:set-cookie-example

Conversation

@handrews

@handrewshandrews commented Aug 21, 2025•
edited by karenetheridge
Loading

Copy link
Copy Markdown
Member

Changes to our understanding of percent-encoding and headers have made the previous example incorrect. This brings it into agreement with the new recommendations.

This also explains how percent-encoding and other escaping is handled, and links to the updated Appendix D which provids more detail including a link to the IETF draft update of the cookie RFC that clarifies this.

  • no schema changes are needed for this pull request

@handrews
Update Set-Cookie example for recent changes
0e8e7e3
Changes to our understanding of percent-encoding and headers
have made the previous example incorrect. This brings it into
agreement with the new recommendations.
This also explains how percent-encoding and other escaping is
handled, and links to the updated Appendix D which provids more
detail including a link to the IETF draft update of the cookie
RFC that clarifies this.
@handrewshandrews added this to the v3.2.0 milestone Aug 21, 2025
@handrewshandrews added examples requests for more or better examples in the specification headers labels Aug 21, 2025
@handrews
handrews requested review from a team as code ownersAugust 21, 2025 16:14
baywet
baywet reviewed Aug 21, 2025
View reviewed changes
Comment threadsrc/oas.md Outdated
karenetheridge
karenetheridge reviewed Aug 21, 2025
View reviewed changes
Comment threadsrc/oas.md Outdated
lornajane
lornajane reviewed Aug 21, 2025
View reviewed changes
Comment threadsrc/oas.md
karenetheridge
karenetheridge reviewed Aug 21, 2025
View reviewed changes
Comment threadsrc/oas.md
@baywetbaywet mentioned this pull request Aug 21, 2025
Closed
@handrewshandrews mentioned this pull request Aug 21, 2025
Merged
3 tasks
@handrews@baywet@karenetheridge
Apply suggestions from code review
125c34c
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
Co-authored-by: Karen Etheridge <ether@cpan.org>
handrews
handrews commented Aug 21, 2025
View reviewed changes

@handrewshandrews left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the remaining thing soon- I think all suggestions are either accepted or I've replied with why I do not think they should be, at least as part of this PR.

Comment threadsrc/oas.md
@handrews

handrews commented Aug 21, 2025

Copy link
Copy Markdown
MemberAuthor

@lornajane I have fixed the example and added a note with further explanation about why this looks different from "Hello, world!" in the cookie input parameter example from PR #4902.

@karenetheridge as with the other PR, I will gladly approve a PR changing the formatting for dataValue in all examples at once, after this is merged.

@ralfhandl
ralfhandl merged commit d17c44d into OAI:v3.2-devAug 25, 2025
2 checks passed
@handrews
handrews deleted the set-cookie-example branch August 27, 2025 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralfhandlralfhandlralfhandl approved these changes
@miquimiquimiqui approved these changes
@lornajanelornajaneAwaiting requested review from lornajane
@karenetheridgekarenetheridgeAwaiting requested review from karenetheridge
@baywetbaywetAwaiting requested review from baywet

Assignees

No one assigned

Labels

examplesrequests for more or better examples in the specificationheaders

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@handrews@lornajane@karenetheridge@ralfhandl@miqui@baywet