Skip to content

v3.2 schema edits - #4957

Merged
lornajane merged 9 commits into
OAI:v3.2-devfrom
karenetheridge:ether/v3.2-schema-remnants
Sep 18, 2025
Merged

v3.2 schema edits#4957
lornajane merged 9 commits into
OAI:v3.2-devfrom
karenetheridge:ether/v3.2-schema-remnants

Conversation

@karenetheridge

@karenetheridgekarenetheridge commented Sep 15, 2025

Copy link
Copy Markdown
Member

Several schema improvements for v3.2. One of them MUST be in the release, as it allows for the use of in: cookie, style: cookie that was prohibited before.

I will backport to v3.1 the things that are relevant there.

  • schema changes are included in this pull request

@karenetheridge
karenetheridge requested review from a team as code ownersSeptember 15, 2025 19:17
@karenetheridgekarenetheridge added the Schema changes related to the schema(s) label Sep 15, 2025
@karenetheridgekarenetheridge added this to the v3.2.0 milestone Sep 15, 2025
@karenetheridge
remove redundant "requires"
9ac8910
- "in" is always required for "parameter"
- "type" is required for "security-scheme"
@karenetheridge
whitespace
c4673bc
@karenetheridge
remove confusing use of json within yaml
c602ca6
@karenetheridge
karenetheridgeforce-pushed the ether/v3.2-schema-remnants branch from b1376fa to 1b20dbcCompareSeptember 15, 2025 19:25
ralfhandl
ralfhandl requested changes Sep 15, 2025
View reviewed changes

@ralfhandlralfhandl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case pass/path_item_servers_parameters.yaml fails with these schema changes.

Comment threadsrc/schemas/validation/schema.yaml
@karenetheridgekarenetheridge mentioned this pull request Sep 15, 2025
Merged
1 task
@karenetheridge
karenetheridgeforce-pushed the ether/v3.2-schema-remnants branch from 1b20dbc to 39cca69CompareSeptember 15, 2025 20:40
@karenetheridge

karenetheridge commented Sep 15, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks, I've fixed the test failure.

ralfhandl

This comment was marked as resolved.

Sign in to view

@ralfhandl
ralfhandl self-requested a review September 15, 2025 20:54
ralfhandl
ralfhandl previously approved these changes Sep 15, 2025
View reviewed changes
@ralfhandl
ralfhandl requested a review from a teamSeptember 15, 2025 20:57
@karenetheridge

karenetheridge commented Sep 15, 2025

Copy link
Copy Markdown
MemberAuthor

style is not required in the parameter object: it's disallowed when combined with content, and style can be omitted to allow its default value to be used in lieu.

@karenetheridge
karenetheridgeforce-pushed the ether/v3.2-schema-remnants branch from 0a03cfc to 2d201d6CompareSeptember 16, 2025 05:20
@karenetheridge

karenetheridge commented Sep 16, 2025

Copy link
Copy Markdown
MemberAuthor

I edited the querystring commit to add:

  • the same constraint added for parameters in path-item as operation
  • disallowed more than one querystring

Because of the restrictions appearing in two places (path-item and operation) I created a new definition for parameters.

@karenetheridge
karenetheridgeforce-pushed the ether/v3.2-schema-remnants branch from 2d201d6 to 2463bd0CompareSeptember 16, 2025 05:40
@ralfhandl
ralfhandl requested a review from a teamSeptember 16, 2025 07:09
@karenetheridge

karenetheridge commented Sep 18, 2025

Copy link
Copy Markdown
MemberAuthor

I found one more thing to add, but I'll make a new PR for that.

whitlockjc
whitlockjc approved these changes Sep 18, 2025
View reviewed changes

@whitlockjcwhitlockjc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mikekistler
mikekistler approved these changes Sep 18, 2025
View reviewed changes

@mikekistlermikekistler left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@lornajane
lornajane merged commit 1919217 into OAI:v3.2-devSep 18, 2025
2 checks passed
@karenetheridge
karenetheridge deleted the ether/v3.2-schema-remnants branch September 18, 2025 16:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whitlockjcwhitlockjcwhitlockjc approved these changes
@ralfhandlralfhandlralfhandl approved these changes
@mikekistlermikekistlermikekistler approved these changes

Assignees

No one assigned

Labels

Schemachanges related to the schema(s)

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@karenetheridge@whitlockjc@ralfhandl@mikekistler@lornajane