Uh oh!
There was an error while loading. Please reload this page.
Clenup JS test. Resolve external $ref during tests. - #591
Conversation
IvanGoncharov
commented
Mar 3, 2016
@webron I force Travis run on this PR and it pass. |
fehguy
commented
Mar 3, 2016
Hi, all tests for OAI V3 should be against the OpenApi.next branch. |
IvanGoncharov
commented
Mar 3, 2016
@fehguy Hi, thank you for reply.
It's not intended for OAI V3. It's fixing and improving test for Swagger v2.0. Can you please review it? P.S. same code can be extended to validate OAI V3 in future. So this PR important for both versions. |
IvanGoncharov
commented
Mar 3, 2016
Code is very simple and straightforward and takes only 63 lines after cleanup. |
IvanGoncharov
commented
Mar 8, 2016
IvanGoncharov
commented
Mar 14, 2016
Clenup JS test. Resolve external $ref during tests.
IvanGoncharov
commented
Mar 16, 2016
webron
commented
Mar 16, 2016
@IvanGoncharov we should probably decide first that that's the current goal. That discussion was prior to the OAI. |
IvanGoncharov
commented
Mar 17, 2016
@webron I understand. As for my personal goals, I want to push few schema fixes to |
Clenup JS test. Resolve external $ref during tests.
Main improvements:
package.json. Mark it as private package to forbid publishing.swagger-validatoris totally [different] https://www.npmjs.com/package/swagger-validator) package on npm.z-schema.tv4validation. It was failing for long period and was marked as expected. Another point is I'm working on switching unittests from Java to JS as disscussed here, and it easy to do onz-schemabut is very hard ontv4.@webron Can you please review it?