No update template (QWeb) views updated by OpenUpgrade get openupgrade_scripts path in arch_fs

[remi-filament]

Module

openupgrade_framework

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Get a database in v17 with at least digest installed and upgrade to v18 (same occurs between v16 and v17)
When updating
The arch_fs field of template ir.ui.views is set to e.g. openupgrade_scripts/scripts/digest/17.0.1.1/noupdate_changes.xml
With this arch_fs, it is no longer possible to Compare / Reinit view to file based view since it cannot be found anymore once DB is moved to final server (without openupgrade_scripts)

Expected behavior
QWeb views should keep arch_fs from odoo modules, not be replaced by openupgrade_scripts source

For instance on a database migrated from v16 to v17 then to v18 :

# select id,name,arch_fs,type from ir_ui_view where arch_fs like '%openupgrade%';

id	name	arch_fs	type
3277	digest_mail_layout	openupgrade_scripts/scripts/digest/17.0.1.1/noupdate_changes.xml	qweb
3647	project_message_user_assigned	openupgrade_scripts/scripts/project/17.0.1.3/noupdate_changes.xml	qweb
3280	digest_tool_kpi	openupgrade_scripts/scripts/digest/17.0.1.1/noupdate_changes.xml	qweb
3460	candidate_hired_template	openupgrade_scripts/scripts/hr_recruitment/18.0.1.1/noupdate_changes_work.xml	qweb
2472	portal_share_template	openupgrade_scripts/scripts/portal/17.0.1.0/noupdate_changes.xml	qweb
3279	digest_section_mobile	openupgrade_scripts/scripts/digest/17.0.1.1/noupdate_changes.xml	qweb
3278	digest_mail_main	openupgrade_scripts/scripts/digest/18.0.1.1/noupdate_changes.xml	qweb

[remi-filament]

Hi @hbrunn do you think this one can be fixed in openupgrade_framework somewhere ?

[hbrunn]

not sure at the moment if we need to do this in openupgrade_framework or openupgradelib. Relevant linkt to code are https://github.com/OCA/OCB/blob/18.0/odoo/addons/base/models/ir_ui_view.py#L254 https://github.com/OCA/OCB/blob/18.0/odoo/tools/convert.py#L334

[aurelien-tempo]

Hi,
The issue seems fixed when migrating from 17 to 18 but still occurs from 16 to 17. Would it be possible to backport the fix ?
I got the issue for portal.portal_share_template from 16 to 17 as an example.
Kind regards.