Skip to content

8.0 add 'map_values' function (onesteinbv) - #118

Closed
legalsylvain wants to merge 2 commits into
OCA:8.0from
OpenUpgrade-dev:8.0-openupgrade-onesteinbv
Closed

legalsylvain wants to merge 2 commits into
OCA:8.0from
OpenUpgrade-dev:8.0-openupgrade-onesteinbv

Conversation

@legalsylvain

Copy link
Copy Markdown
Contributor

Port 'core' modification of openupgrade realized by OneStein BV. (branch onesteinbv:8.0-os)

@legalsylvain legalsylvain added this to the 8.0 milestone Oct 28, 2014
@legalsylvain legalsylvain changed the title [ADD] [8.0] add 'map_values' function in openupgrade framework; 8.0 add 'map_values' (onesteinbv) Oct 28, 2014
@legalsylvain legalsylvain changed the title 8.0 add 'map_values' (onesteinbv) 8.0 add 'map_values' function (onesteinbv) Oct 28, 2014
Comment thread openerp/openupgrade/openupgrade.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also check if source_column is different from target_column.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Are you ok with the changes ?

@StefanRijnhart

Copy link
Copy Markdown
Member

👎 Taken from https://github.com/OpenUpgrade/OpenUpgrade/pull/80/files. Review this first please.

@legalsylvain

Copy link
Copy Markdown
Contributor Author

@StefanRijnhart : Agree.
👎
Thanks.

GuillemCForgeFlow pushed a commit to ForgeFlow/OpenUpgrade that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants