[17.0][FIX] account: copy imd entry without ir.model.data's random name mechanism - #4806
Merged
Merged
Conversation
Comment on lines
+423
to
+424
| models.BaseModel.copy( | ||
| imd, |
Contributor
There was a problem hiding this comment.
Suggested change
| models.BaseModel.copy( | |
| imd, | |
| imd.copy( |
Why not this?
Member
Author
There was a problem hiding this comment.
because the override linked above overwrites the name with a randomly generated one, and the write in the first version only happens when the transaction is flushed. When the next create generates a new name, there doesn't seem to be enough randomness in the container to create a new name
MiquelRForgeFlow
approved these changes
Mar 11, 2025
Contributor
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 5e6ac9f. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this avoids the override that causes tests to fail randomly in docker container, probably some entropy issue