Uh oh!
There was an error while loading. Please reload this page.
[REF] contract - pass self instead of relying on @api.model - #1497
Open
anthonissen-a wants to merge 1 commit into
Open
[REF] contract - pass self instead of relying on @api.model#1497anthonissen-a wants to merge 1 commit into
anthonissen-a wants to merge 1 commit into
Conversation
OCA-git-bot
commented
Aug 12, 2026
Contributor
Hi @sbejaoui, @florian-dacosta, |
anthonissen-aforce-pushed
the
18.0-ref-contract_remove_static_args-aan
branch
from
August 12, 2026 08:51
5a767be to
6b89846Compareanthonissen-aforce-pushed
the
18.0-ref-contract_remove_static_args-aan
branch
from
August 12, 2026 11:57
6b89846 to
73138e4Compareanthonissen-a
marked this pull request as ready for review
August 12, 2026 12:04
qgroulard
approved these changes
Aug 12, 2026
qgroulard
left a comment
Contributor
There was a problem hiding this comment.
Great changes 👍
This is backward compatible and it highly improves the extensibility of get_next_invoice_date and get_next_period_date_end for other OCA modules and custom code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
@api.modelmethods with instance methods across contract methods to improve extensibility and allow overrides to access record data inself.Method parameters are now optional to ensure full backward compatibility.