[9.0] [MIG] website_sale_require_legal module - #144
Merged
Merged
Conversation
cubells
force-pushed
the
9.0-mig-website_sale_require_legal
branch
from
November 28, 2016 11:38
b6cfa82 to
9927793
Compare
pedrobaeza
requested changes
Nov 28, 2016
| { | ||
| "name": "Require accepting legal terms to checkout", | ||
| "summary": "Force the user to accept legal tems to buy in the web shop", | ||
| "version": "9.0.1.1.0", |
|
|
||
| This module was written to extend the functionality of your website shop to | ||
| support forcing the user to accept your legal advice, terms of use and privacy | ||
| policy, and allow you to obey some countries' laws. |
| "license": "AGPL-3", | ||
| "application": False, | ||
| "installable": True, | ||
| "external_dependencies": { |
Member
|
Please rebase on current 9.0 branch, because I have fixed .travis.yml for allowing sass command. |
Member
Author
|
Is Travis error related to another module? |
Member
|
Travis is failing due to website_sale_wishlist module, so not related. |
Member
|
Please rebase again, as sass command is still not working. |
cubells
force-pushed
the
9.0-mig-website_sale_require_legal
branch
from
November 30, 2016 07:31
63c8203 to
bf355e8
Compare
Member
|
This addon breaks a tour in |
Member
|
The error is also on base branch, so it's not something of this branch. @yajo, please fix it on another PR. |
Member
|
I hope #149 and OCA/server-tools#666 fix it. |
Member
|
You need to rebase. |
cubells
force-pushed
the
9.0-mig-website_sale_require_legal
branch
3 times, most recently
from
December 23, 2016 06:57
cbd738b to
770a691
Compare
yajo
force-pushed
the
9.0-mig-website_sale_require_legal
branch
from
January 4, 2017 12:08
770a691 to
36b20df
Compare
yajo
approved these changes
Jan 5, 2017
yajo
left a comment
Member
There was a problem hiding this comment.
There's a coverage drop, but code & functional test passed.
pedrobaeza
force-pushed
the
9.0-mig-website_sale_require_legal
branch
from
January 5, 2017 21:02
36b20df to
f8cad91
Compare
pedrobaeza
approved these changes
Jan 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Tecnativa