Conversation
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers the migration to v10 and actually a [FIX] which is explained in my docstring of the controller:
In my case when I choose
Apple Wirless Keyboardas an optional product for theiMac, there was unexpected behaviour: Theproduct_idsent via AJAX request is based on theproduct.productID, which was19, while the correspondingproduct.templateID was16(if I recall correctly). So this lead to the effect, that choosing the keyboard in the frontend didn't lead to it being recognised as an optional product. I fixed this by "converting" theproduct.productID to its correspondingproduct.templateID.I didn't check if this bug is also existent in earlier Odoo versions.
@pedrobaeza Somehow this PR also contains my commits from earlier today. I proceeded accordingly to your comment on my
website_sale_order_companyPR. Not sure if I did something wrong or this behaviour is normal.