Skip to content

[10.0][MIG] website_sale_unsaleable_options - #186

Closed
reinka wants to merge 11 commits into
OCA:10.0from
reinka:10.0-mig-website_sale_unsaleable_options
Closed

reinka wants to merge 11 commits into
OCA:10.0from
reinka:10.0-mig-website_sale_unsaleable_options

Conversation

@reinka

@reinka reinka commented Jun 24, 2017

Copy link
Copy Markdown

This PR covers the migration to v10 and actually a [FIX] which is explained in my docstring of the controller:

[...]
optional_product_ids is saved on product.template.
However, the AJAX request sends the product_id saved
on product.product! Since these 2 IDs can vary, we have
to consider such cases here.
[...]

In my case when I choose Apple Wirless Keyboard as an optional product for the iMac, there was unexpected behaviour: The product_id sent via AJAX request is based on the product.product ID, which was 19, while the corresponding product.template ID was 16 (if I recall correctly). So this lead to the effect, that choosing the keyboard in the frontend didn't lead to it being recognised as an optional product. I fixed this by "converting" the product.product ID to its corresponding product.template ID.
I didn't check if this bug is also existent in earlier Odoo versions.

@pedrobaeza Somehow this PR also contains my commits from earlier today. I proceeded accordingly to your comment on my website_sale_order_company PR. Not sure if I did something wrong or this behaviour is normal.

@yajo yajo added this to the 10.0 milestone Jun 26, 2017
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 26, 2021
@github-actions github-actions Bot closed this Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants