9.0 mgmtsystem nonconformity

[naousse]

No description provided.

[coveralls]

Coverage remained the same at 100.0% when pulling ddf5be1 on naousse:9.0-mgmtsystem_nonconformity into 18b9b4c on OCA:9.0.

[naousse]

@dreispt
Please Daniel, i need your help here. I'm unable to register a nonconformity because of this method that doesn't work.

[dreispt]

I don't think this fieds is needed. State alone is enough.

[max3903]

@naousse You can rebase this branch now.

[max3903]

@naousse

• The create button has disappeared when you click on nonconformity in the menu
• Drag and drop in the kanban view is not working
• Merge [IMP] README.rst naousse/management-system#7 to improve README file
• The "Close" button has disappeared. I had to click on "Closed" in the workflow steps to close the NC
• Check the form view on branch 8.0, I think the action plan comments and effectiveness review fields have been improved

[dreispt]

@max3903 I didn't get this one:

When the NC is in progress state/stage, the actions of the plan should be opened.

[dreispt]

@naousse naousse#11 implements it and a few other improvements/fixes - check the commit messages

[max3903]

• I was able to move the NC to the In Progress state/stage without the plan review. I should get an error message and be asked to enter it.
• In the chatter of a nonconformity, the state/stage changes appears twice in each message
• When the NC is in progress state/stage, the actions of the plan should be opened.
• The menu item for report is not consistent with the others: Nonconformity --> Nonconformities

See http://3151194-140-e585e9.runbot2.odoo-community.org/web#id=2&view_type=form&model=mgmtsystem.nonconformity&menu_id=131&action=120

[dreispt]

When the NC is in progress state/stage, the actions of the plan should be opened.

I don't understand this.

[max3903]

@dreispt Actions are in draft until the action plan is reviewed. Once done, actions are opened and assignees can start working on them.

[dreispt]

There you go: naousse#12 should fix those issues.
During tests, I figured that the "Pending Approval" stage wasn't intuitive, so I renamed it to "Action Plan".

[max3903]

•  I was able to close the NC with one action opened. I should get an error message and be asked to close every actions first (the immediate action and the ones of the action plan).

Otherwise 👍

[dreispt]

There you go naousse#13

[dreispt]

Coverage back to 100% 😺

[max3903]

👍 Good work guys!

[dreispt]

🏆