Skip to content

[16.0][MIG] mis_builder_budget: Migration to 16.0 - #488

Closed
dzungtran89 wants to merge 13 commits into
OCA:16.0from
dzungtran89:16.0-mis_builder_budget
Closed

dzungtran89 wants to merge 13 commits into
OCA:16.0from
dzungtran89:16.0-mis_builder_budget

Conversation

@dzungtran89

Copy link
Copy Markdown
Contributor

@Camille0907 Camille0907 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks technically good, but please fix CI :)

@dzungtran89
dzungtran89 force-pushed the 16.0-mis_builder_budget branch from e946049 to 4909f03 Compare March 3, 2023 08:45
@sbidoul

sbidoul commented Mar 12, 2023

Copy link
Copy Markdown
Member

Thanks! Can you send this as a PR to acsone:16.0-mig-mis_builder-ape. It will be easier to test everything together.

@dzungtran89
dzungtran89 force-pushed the 16.0-mis_builder_budget branch from 4909f03 to dfcbb9f Compare March 13, 2023 09:24
@dzungtran89

Copy link
Copy Markdown
Contributor Author

Thanks! Can you send this as a PR to acsone:16.0-mig-mis_builder-ape. It will be easier to test everything together.

@sbidoul the PR has been created to the target branch

@sbidoul
sbidoul marked this pull request as draft March 14, 2023 17:54
@StephaneMangin

Copy link
Copy Markdown

For the PR dependency, please take in account this comment OCA/edi#724 (comment)

@dzungtran89

Copy link
Copy Markdown
Contributor Author

Hi @StephaneMangin , the dependency has already included in this commit

@sbidoul

sbidoul commented Mar 24, 2023

Copy link
Copy Markdown
Member

mis_builder_budget is now included in #472, so closing this one.

@sbidoul sbidoul closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants