Skip to content

[13.0][MIG] migration of module report_qweb_operating_unit - #255

Merged
OCA-git-bot merged 8 commits into
OCA:13.0from
Jarsa-dev:13.0-mig-report_qweb_operating_unit
Feb 18, 2020
Merged

OCA-git-bot merged 8 commits into
OCA:13.0from
Jarsa-dev:13.0-mig-report_qweb_operating_unit

Conversation

@alan196

@alan196 alan196 commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

Proposed changes

I've migrated the module report_qweb_operating_unit and it's functionalities from Odoo 12.0 to 13.0.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated necessary documentation

Additional Comments

I adapted this module to print the data from the operating unit instead of the company if the operating unit is defined on the model and if the model doesn't have the field operating_unit_id it will use the company data.

I also adapt this to every type of report that you can choose in the system configuration in the following screen:

Captura de Pantalla 2020-02-13 a la(s) 12 10 31

Here is an example of every report type.
The first image is an invoice with operating_unit_id defined and partner Azure Interior defined in the operating unit.
The second image is a sale order without the sale_operating_unit module installed.

Standard Design

Captura de Pantalla 2020-02-13 a la(s) 12 13 24
Captura de Pantalla 2020-02-13 a la(s) 12 13 40

Background Design

Captura de Pantalla 2020-02-13 a la(s) 12 15 33
Captura de Pantalla 2020-02-13 a la(s) 12 15 43

Boxed Design

Captura de Pantalla 2020-02-13 a la(s) 12 21 08
Captura de Pantalla 2020-02-13 a la(s) 12 21 27

Clean Design

Captura de Pantalla 2020-02-13 a la(s) 12 22 40
Captura de Pantalla 2020-02-13 a la(s) 12 22 51

@alan196
alan196 force-pushed the 13.0-mig-report_qweb_operating_unit branch from 6505419 to 1a376bc Compare February 13, 2020 18:05
@alan196
alan196 force-pushed the 13.0-mig-report_qweb_operating_unit branch from 1a376bc to 4a757e8 Compare February 13, 2020 18:26
@alan196 alan196 mentioned this pull request Feb 13, 2020
14 tasks
@AaronHForgeFlow

Copy link
Copy Markdown
Contributor

Nice improvement! ❤️

I will try to to backport it to v12 too.

@AaronHForgeFlow AaronHForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works as expected

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow

Copy link
Copy Markdown
Contributor

/ocabot merge

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-255-by-AaronHForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 18, 2020
Signed-off-by AaronHForgeFlow
@OCA-git-bot
OCA-git-bot merged commit 4a757e8 into OCA:13.0 Feb 18, 2020
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 67111a5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants