Skip to content

[14.0][FIX] purchase_operating_unit: default picking_type without OU - #647

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
PyTech-SRL:14.0-purchase-ou-default
Jan 19, 2024
Merged

[14.0][FIX] purchase_operating_unit: default picking_type without OU#647
OCA-git-bot merged 1 commit into
OCA:14.0from
PyTech-SRL:14.0-purchase-ou-default

Conversation

@HekkiMelody

@HekkiMelody HekkiMelody commented Jan 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes an issue when creating a PO, if the user doesn't have any operating units assigned.

AaronHForgeFlow
AaronHForgeFlow reviewed Jan 19, 2024
View reviewed changes
Comment thread purchase_operating_unit/models/purchase_order.py Outdated
@HekkiMelody
HekkiMelody force-pushed the 14.0-purchase-ou-default branch from 47f04f9 to 5c3f386 Compare January 19, 2024 09:53
francesco-ooops
francesco-ooops approved these changes Jan 19, 2024
View reviewed changes

@francesco-ooops francesco-ooops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@AaronHForgeFlow good for you?

AaronHForgeFlow
AaronHForgeFlow approved these changes Jan 19, 2024
View reviewed changes

@AaronHForgeFlow AaronHForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the explanation

@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Jan 19, 2024
Open
@AaronHForgeFlow

AaronHForgeFlow commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

/ocabot merge patch

If you do the FW to 15.0 it would merge it right away

@OCA-git-bot

OCA-git-bot commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-647-by-AaronHForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 09be749 into OCA:14.0 Jan 19, 2024
@OCA-git-bot

OCA-git-bot commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at cc5a614. Thanks a lot for contributing to OCA. ❤️

@HekkiMelody

HekkiMelody commented Jan 19, 2024

Copy link
Copy Markdown
Contributor Author

Thank you @AaronHForgeFlow !

@HekkiMelody
HekkiMelody deleted the 14.0-purchase-ou-default branch January 19, 2024 11:26
@HekkiMelody

HekkiMelody commented Jan 19, 2024

Copy link
Copy Markdown
Contributor Author

The method I'm fixing isn't even present in v15, I'm afraid it'll require to FW multiple commits to align the versions...

@francesco-ooops

francesco-ooops commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

@AaronHForgeFlow can you make an analysis of commits in v14 missing in v15?

@AaronHForgeFlow

AaronHForgeFlow commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

hmmm, theoretically every PR merged is forward ported to new versions. I will check when I have some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes
+1 more reviewer
@francesco-ooops francesco-ooops francesco-ooops approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HekkiMelody @AaronHForgeFlow @OCA-git-bot @francesco-ooops