Skip to content

[16.0][MIG] account_operating_unit - #656

Merged
OCA-git-bot merged 108 commits into
OCA:16.0from
hbrunn:16.0-mig-account_operating_unit
Jul 30, 2024
Merged

OCA-git-bot merged 108 commits into
OCA:16.0from
hbrunn:16.0-mig-account_operating_unit

Conversation

@hbrunn

@hbrunn hbrunn commented Mar 14, 2024

Copy link
Copy Markdown
Member

TODO

  • patch the analytic distribution widget to inject the operating unit into the analytic account domain
  • add tests for account.bank.statement.line

The module is already perfectly functional, but I don't consider the migration to be properly done without this

sudhir-serpentcs and others added 30 commits March 14, 2024 16:17
…f setting an inter-OU accounts triggers from other modules when creating companies
* Add management of payments using operating units
* Trial Balance by operating units
* Improve tests

@AaronHForgeFlow AaronHForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @hbrunn I think the module works ok. Only pending the 2 items you mentioned. Can you consider to incluide this? #658

@houssine78 houssine78 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronHForgeFlow

Copy link
Copy Markdown
Contributor

To be also included: #685 Thanks

@hbrunn

hbrunn commented Jul 8, 2024

Copy link
Copy Markdown
Member Author

note that I won't be working on this any time soon, so whoever has a stake in this migration, please implement the missing points above and cherry pick the commits mentioned

hbrunn and others added 5 commits July 18, 2024 17:57
with different operating units.

That was possible in old versions <v12 but it was removed for unknown
reason.

In general, reconciling a bank journal entry with an invoice
will require Inter OU balancing entries, as long one OU is paying
the balance for the other.
…rpart base line

This commit adds the operating unit to the cash basis counterpart base line
when cash basis accounting is enabled.
@hbrunn
hbrunn force-pushed the 16.0-mig-account_operating_unit branch from 5579a49 to f0c0e9c Compare July 18, 2024 15:57
@hbrunn

hbrunn commented Jul 18, 2024

Copy link
Copy Markdown
Member Author

@AaronHForgeFlow picked the commits you requested and added the patch for the widget

@AaronHForgeFlow

Copy link
Copy Markdown
Contributor

@hbrunn Thank you! I will do a functional review.

@hbrunn

hbrunn commented Jul 26, 2024

Copy link
Copy Markdown
Member Author

/ocabot migration account_operating_unit

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 26, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 26, 2024
10 tasks
@hbrunn hbrunn mentioned this pull request Jul 26, 2024
1 task

@AaronHForgeFlow AaronHForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, it works as expected. Thanks

@AaronHForgeFlow

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-656-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 83f8a6e into OCA:16.0 Jul 30, 2024
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 7b751c5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.