[10.0] [ADD] purchase_requisition_operating_unit by serpentcs-dev1 · Pull Request #81 · OCA/operating-unit

serpentcs-dev1 · 2017-07-06T12:37:20Z

Purchase Requisition with Operating Units

This module introduces the following features:

Security rules are defined to ensure that users can only see the Purchase Requisition of that Operating Units in which they are allowed access to.
Ensures that Purchase Requisition and the Warehouse in picking type belongs to the same Operating Unit (OU) .
When the user creates a Purchase Order (PO) from the purchase requisition the operating unit is passed to that PO.
Sets default Picking type whoes Operating Unit (OU) in Warehouse matches to that of the User.

nikul-serpentcs · 2017-07-06T12:57:16Z

@aheficent Please review code.

AaronHForgeFlow

Only code review

AaronHForgeFlow · 2017-07-06T13:56:13Z

+                    and rec.operating_unit_id and\
+                    picking_type.warehouse_id.operating_unit_id !=\
+                        rec.operating_unit_id:
+                    raise UserError(_('Configuration error!\nThe Operating \


\n is not need, just close the quotes and open those again in the next line

@aheficent Removed '\n' and quotes open next line.
Please review code.

AaronHForgeFlow · 2017-07-06T13:57:00Z

+                                     ('warehouse_id.operating_unit_id', '=',
+                                      self.operating_unit_id.id)])
+            if types:
+                self.picking_type_id = types[:1]


Why don't you use the first?

@aheficent
[:1] in find first record

@aheficent
Python slicing in find first value.

serpentcs-dev1 · 2017-07-07T10:06:42Z

+    "license": "LGPL-3",
+    "website": "http://www.eficent.com",
+    "category": "Purchase Management",
+    "depends": ["purchase_requisition",


@aheficent Waiting for #368 to get merged.

I guess then we need to add purchase-workflow to the oca_dependencies, right?

Don't know though why the travis is already green now?!

AaronHForgeFlow

👍 LGTM Thanks. Can you please squash the commits before this is merged?

nikul-serpentcs · 2017-08-21T05:42:32Z

@aheficent squashed commits, Please check it.

AaronHForgeFlow · 2017-09-04T13:28:55Z

+        for rec in self:
+            if rec.company_id and rec.operating_unit_id and \
+                    rec.company_id != rec.operating_unit_id.company_id:
+                raise UserError(_('The Company in the Purchase Requisition and'


I'll be great if you include and assertRaises in the test for this one 🏅

nikul-serpentcs · 2017-09-06T09:19:21Z

@aheficent included assertRaises in the test case, Please check it.

AaronHForgeFlow

@nikul-serpentcs codecov covers 100% of the lines don't know why it's red

nikul-serpentcs · 2017-09-06T09:57:13Z

@aheficent Rebased branch and codecov is Happy.

[FIX] remove reference to warehouse [ENH] purchase_request_operating_unit, purchase_rquest_procurement_operating_unit 9.0 purchase request operating unit - fixed travis (OCA#81) * [FIX] travis

AaronHForgeFlow · 2018-04-10T10:51:54Z

+                    and rec.operating_unit_id and\
+                    picking_type.warehouse_id.operating_unit_id !=\
+                        rec.operating_unit_id:
+                    raise UserError(_('Configuration error! The Operating '


Can you avoid exclamation marks in the error messages? People may feel bad when getting a message like this

AaronHForgeFlow · 2018-04-10T10:52:19Z

+            if types:
+                self.picking_type_id = types[:1]
+            else:
+                raise UserError(_("No Warehouse found with the "


MiquelRForgeFlow · 2018-06-27T11:56:24Z

+                    and rec.operating_unit_id and\
+                    picking_type.warehouse_id.operating_unit_id !=\
+                        rec.operating_unit_id:
+                    raise UserError(_('Configuration error, The Operating '


but the , should be a . @aheficent

done @mreficent thanks

[FIX] remove reference to warehouse [ENH] purchase_request_operating_unit, purchase_rquest_procurement_operating_unit 9.0 purchase request operating unit - fixed travis (#81) * [FIX] travis

[FIX] remove reference to warehouse [ENH] purchase_request_operating_unit, purchase_rquest_procurement_operating_unit 9.0 purchase request operating unit - fixed travis (OCA#81) * [FIX] travis

github-actions · 2021-10-31T12:21:25Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[FIX] remove reference to warehouse [ENH] purchase_request_operating_unit, purchase_rquest_procurement_operating_unit 9.0 purchase request operating unit - fixed travis (OCA#81) * [FIX] travis

AaronHForgeFlow requested changes Jul 6, 2017

View reviewed changes

serpentcs-dev1 force-pushed the 10.0-purchase_requisition_operating_unit branch from b387fe5 to 1196e55 Compare July 7, 2017 05:38

serpentcs-dev1 changed the title ~~10.0 purchase requisition operating unit~~ [10.0] [ADD] purchase_requisition_operating_unit Jul 7, 2017

serpentcs-dev1 commented Jul 7, 2017

View reviewed changes

AaronHForgeFlow approved these changes Jul 10, 2017

View reviewed changes

serpentcs-dev1 force-pushed the 10.0-purchase_requisition_operating_unit branch from ff35807 to d75f0e6 Compare August 19, 2017 07:51

AaronHForgeFlow reviewed Sep 4, 2017

View reviewed changes

AaronHForgeFlow approved these changes Sep 6, 2017

View reviewed changes

serpentcs-dev1 force-pushed the 10.0-purchase_requisition_operating_unit branch from 0edc0b0 to c5264af Compare September 6, 2017 09:35

AaronHForgeFlow added the needs review label Nov 10, 2017

AaronHForgeFlow reviewed Apr 10, 2018

View reviewed changes

AaronHForgeFlow requested a review from MiquelRForgeFlow June 27, 2018 10:42

MiquelRForgeFlow reviewed Jun 27, 2018

View reviewed changes

AaronHForgeFlow force-pushed the 10.0-purchase_requisition_operating_unit branch from 40e101b to 477a462 Compare June 27, 2018 12:10

MiquelRForgeFlow approved these changes Jun 27, 2018

View reviewed changes

SerpentCS added 4 commits June 29, 2018 10:12

Migrated purchase_requisition_ou module to v9

c127bfb

Modified Readme file.

f08b108

Added Copyrights in xml files and made minor changes.

ca44cc9

changed readme file

e23433e

[MIG] purchase_requisition_operating_unit v10

1d7674a

AaronHForgeFlow force-pushed the 10.0-purchase_requisition_operating_unit branch from 477a462 to 1d7674a Compare June 29, 2018 08:12

max3903 added this to the 10.0 milestone Dec 27, 2019

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 31, 2021

github-actions Bot closed this Dec 5, 2021

Uh oh!

Conversation

serpentcs-dev1 commented Jul 6, 2017

Purchase Requisition with Operating Units

Uh oh!

nikul-serpentcs commented Jul 6, 2017

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikul-serpentcs Jul 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serpentcs-dev1 Jul 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

nikul-serpentcs commented Aug 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikul-serpentcs commented Sep 6, 2017

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

nikul-serpentcs commented Sep 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nikul-serpentcs Jul 7, 2017 •

edited

Loading

serpentcs-dev1 Jul 7, 2017 •

edited

Loading

nikul-serpentcs commented Sep 6, 2017 •

edited

Loading