Skip to content

[14.0][ADD] endpoint_product_catalog - #1645

Closed
SilvioC2C wants to merge 2 commits into
OCA:14.0from
camptocamp:14.0-add-endpoint_product_catalog
Closed

[14.0][ADD] endpoint_product_catalog#1645
SilvioC2C wants to merge 2 commits into
OCA:14.0from
camptocamp:14.0-add-endpoint_product_catalog

Conversation

@SilvioC2C

Copy link
Copy Markdown

Allows configuring specific endpoints to expose products catalogs.

@SilvioC2C
SilvioC2C force-pushed the 14.0-add-endpoint_product_catalog branch from 49a900f to 0f7b4fe Compare June 13, 2024 17:39
Comment thread endpoint_product_catalog/__manifest__.py Outdated
Comment thread oca_dependencies.txt
# See https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#oca_dependencies-txt
reporting-engine
server-ux
web-api

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to touch this file but... yeah... maybe somebody is still using it.
Although I'm not sure this is the right place for this module (the repo I mean). Maybe "PIM" is more appropriate even if not directly bound.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I move it to the PIM repo?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know to be honest. Maybe a new repo like web-api-contrib (similar to mis-builder-contrib) would be better...

@sbidoul @lmignon @etobella any opinion?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have an opinion, as I don't see the immediate benefit of such a module. In my mind, exposing an API means exposing a contract and the system must at all times ensure that the data is validated against the contract while being able to provide documentation detailing the terms of the contract.
Apart from this comment, the web-api repo would probably be more appropriate, or a new web-api-contrib repo.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation and documentation will come. ATM is not fundamental and we need some freedom here 😉

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm proposing the new repo here OCA/repo-maintainer-conf#27

Comment thread endpoint_product_catalog/models/ir_filters.py Outdated
Comment thread endpoint_product_catalog/views/ir_filters.xml Outdated
Comment thread endpoint_product_catalog/models/ir_filters.py Outdated
Comment thread endpoint_product_catalog/readme/USAGE.rst
@simahawk

Copy link
Copy Markdown
Contributor

moved to OCA/web-api-contrib#1

@simahawk simahawk closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants