Skip to content

16.0 mig project task code - #1013

Closed
uncannycs wants to merge 47 commits into
OCA:16.0from
uncannycs:16.0-mig-project_task_code
Closed

uncannycs wants to merge 47 commits into
OCA:16.0from
uncannycs:16.0-mig-project_task_code

Conversation

@uncannycs

Copy link
Copy Markdown

No description provided.

oihane and others added 30 commits November 2, 2022 19:24
OCA Transbot updated translations from Transifex

[MIG] project_task_code: Migrate to 10.0

Edit init and XML

Add env

Change task_ids to tasks

Change to @api.multi before def copy
Relational fields and the task notification email inform the task code
- adapted view (label needs a `for` attribute, use span for same result)
- use the `model_create_multi` decorator on the create override for
future-proofiness
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (3 of 3 strings)

Translation: project-12.0/project-12.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_code/gl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_task_code/
OCA-git-bot and others added 17 commits November 2, 2022 19:24
Currently translated at 100.0% (6 of 6 strings)

Translation: project-14.0/project-14.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/es_AR/
Currently translated at 50.0% (3 of 6 strings)

Translation: project-14.0/project-14.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/fr_FR/
Currently translated at 100.0% (3 of 3 strings)

Translation: project-14.0/project-14.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/es_MX/
Currently translated at 100.0% (3 of 3 strings)

Translation: project-14.0/project-14.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/sv/
Currently translated at 100.0% (3 of 3 strings)

Translation: project-15.0/project-15.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_task_code/ca/
The overload of project.task::create  in the project_task_code would
mutate the dictionaries passed in the vals_list argument. This is a bad
practice which can have unintended side effects in caller code.

We fix this by creating a new dictionary containing the additional field
value and passing this dictionary in the call to super().create()
@leemannd

leemannd commented Nov 9, 2022

Copy link
Copy Markdown
Contributor

Hello @uncannycs @kg-ucs The tests are failing. Could you have a look?

@leemannd

leemannd commented Nov 9, 2022

Copy link
Copy Markdown
Contributor

/ocabot migration project_task_code

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 9, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 9, 2022
38 tasks
@leemannd

leemannd commented Dec 1, 2022

Copy link
Copy Markdown
Contributor

Hello @uncannycs @kg-ucs There has been a fix into version 15.0. Could you have a look in order to include it? #1032

@Abranes

Abranes commented Mar 9, 2023

Copy link
Copy Markdown
Member

Superseded by #1084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.