Skip to content

[11.0][base_import_async] - Add dependency to queue_job_batch - #155

Merged
OCA-git-bot merged 1 commit into
OCA:11.0from
ForgeFlow:11.0-add-base_import_async-batch
Jul 9, 2019
Merged

[11.0][base_import_async] - Add dependency to queue_job_batch#155
OCA-git-bot merged 1 commit into
OCA:11.0from
ForgeFlow:11.0-add-base_import_async-batch

Conversation

@JordiBForgeFlow

@JordiBForgeFlowJordiBForgeFlow commented Jul 8, 2019

Copy link
Copy Markdown
Member

This PR adds to the 'base_import_o' module the dependency with 'queue_job_batch' so that the end user can track the progress of the load.

Peek 2019-07-08 13-16

@JordiBForgeFlow

JordiBForgeFlow commented Jul 8, 2019

Copy link
Copy Markdown
MemberAuthor

cc @etobella@sebastienbeau@sbidoul this feature would be nice in data loads.

etobella
etobella approved these changes Jul 8, 2019
View reviewed changes

@etobellaetobella left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
code Review and tested locally 😄

@sbidoul

sbidoul commented Jul 8, 2019

Copy link
Copy Markdown
Member

Yes, that's very nice :)

guewen
guewen reviewed Jul 8, 2019
View reviewed changes

@guewenguewen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool :)

Comment threadbase_import_async/models/base_import_import.py
@etobella

etobella commented Jul 9, 2019

Copy link
Copy Markdown
Member

I have tested it with the last changes of #151 and it works perfectly 😄

@etobella

etobella commented Jul 9, 2019

Copy link
Copy Markdown
Member

Just wondering if something like https://github.com/OCA/server-ux/blob/11.0/base_tier_validation/migrations/11.0.1.2.0/post-migrate.py#L8 is necessary installing queue_job_batch.
WDYT?

@sbidoul

sbidoul commented Jul 9, 2019

Copy link
Copy Markdown
Member

@etobella that should not be necessary, the new dependency will be installed automatically.

@etobella

etobella commented Jul 9, 2019

Copy link
Copy Markdown
Member

Yes, my mistake, I always had issues with this kind of changes, but I did manage it wrongly.

@JordiBForgeFlow
[base_import_async] add dependency with queue_job_batch
11e6f9d
to allow users to monitor the progress of the data load
interactively.
@JordiBForgeFlow
JordiBForgeFlowforce-pushed the 11.0-add-base_import_async-batch branch from b3f8273 to 11e6f9dCompareJuly 9, 2019 15:13
@sbidoul

sbidoul commented Jul 9, 2019

Copy link
Copy Markdown
Member

/ocabot merge

@OCA-git-bot

OCA-git-bot commented Jul 9, 2019

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Rebased to 11.0-ocabot-merge-pr-155-by-sbidoul-bump-no, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 11e6f9d into OCA:11.0Jul 9, 2019
OCA-git-bot added a commit that referenced this pull request Jul 9, 2019
@OCA-git-bot
Merge PR#155into 11.0
6461dab
Signed-off-by sbidoul
@OCA-git-bot

OCA-git-bot commented Jul 9, 2019

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 6461dab. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

@LoisRForgeFlow
LoisRForgeFlow deleted the 11.0-add-base_import_async-batch branch July 10, 2019 08:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guewenguewenguewen approved these changes
@sbidoulsbidoulsbidoul approved these changes
@etobellaetobellaetobella approved these changes

Assignees

No one assigned

Labels

approvedmerged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JordiBForgeFlow@sbidoul@etobella@OCA-git-bot@guewen