Uh oh!
There was an error while loading. Please reload this page.
Do not save session in /queue_job/runjob route - #252
Merged
Conversation
OCA-git-bot
commented
Aug 28, 2020
Contributor
Hi @guewen, |
guewen
commented
Sep 30, 2020
Member
Much less code, I love it :) |
sbidoul
marked this pull request as ready for review
October 1, 2020 13:58
simahawk
approved these changes
Oct 2, 2020
simahawk
left a comment
Contributor
There was a problem hiding this comment.
not tested but the change seems legit
lmignon
approved these changes
Oct 2, 2020
lmignon
left a comment
Contributor
There was a problem hiding this comment.
No test but if the functionality is provided by Odoo ...
guewen
commented
Oct 9, 2020
Member
/ocabot merge patch |
OCA-git-bot
commented
Oct 9, 2020
Contributor
This PR looks fantastic, let's merge it! |
OCA-git-bot
commented
Oct 9, 2020
Contributor
Congratulations, your PR was merged at a089cb1. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since odoo/odoo@f65528a routes have a
save_sessionoption.We can simplify the job runner by making use of it.
This is currently lUNTESTED.