Skip to content

Store worker's PID when a job is started - #258

Merged
OCA-git-bot merged 1 commit into
OCA:13.0from
guewen:13.0-store-pid
Nov 13, 2020
Merged

Store worker's PID when a job is started#258
OCA-git-bot merged 1 commit into
OCA:13.0from
guewen:13.0-store-pid

Conversation

@guewen

@guewenguewen commented Oct 1, 2020

Copy link
Copy Markdown
Member

Add a field in the "queue_job" model to store the worker pid.
No usage for new besides "logging" for debugging (helps to find which
process to investigate in case a job is stuck).
Later, it may be useful to improve the recovery of job that stay in the
wrong state when the job runner restarts.

Closes#177

Guewen Baconnier
Store worker's PID when a job is started
b21ce12
Add a field in the "queue_job" model to store the worker pid.
No usage for new besides "logging" for debugging (helps to find which
process to investigate in case a job is stuck).
Later, it may be useful to improve the recovery of job that stay in the
wrong state when the job runner restarts.
ClosesOCA#177
@guewen
guewen requested a review from sbidoulOctober 1, 2020 15:31
sbidoul
sbidoul approved these changes Oct 1, 2020
View reviewed changes

@sbidoulsbidoul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding with one ear while listening to talks with the other ?

Thanks for implementing this !

@guewen

guewen commented Nov 13, 2020

Copy link
Copy Markdown
MemberAuthor

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-258-by-guewen-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 13, 2020
@OCA-git-bot
Merge PR#258into 13.0
6b158fe
Signed-off-by guewen
@OCA-git-bot

OCA-git-bot commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-258-by-guewen-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 13, 2020
@OCA-git-bot
Merge PR#258into 13.0
1d9e26e
Signed-off-by guewen
@OCA-git-bot

OCA-git-bot commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-258-by-guewen-bump-minor, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 205c39b into OCA:13.0Nov 13, 2020
@OCA-git-bot

OCA-git-bot commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 4ae3e86. Thanks a lot for contributing to OCA. ❤️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawksimahawksimahawk approved these changes
@sbidoulsbidoulsbidoul approved these changes

Assignees

No one assigned

Labels

approvedmerged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[idea] store worker PID on the queue.job record when starting a job

4 participants

@guewen@OCA-git-bot@simahawk@sbidoul