Skip to content

[ON HOLD][13.0] Add job_auto_delay decorator - #270

Closed
guewen wants to merge 1 commit into
OCA:13.0from
guewen:13.0-job_auto_delay
Closed

[ON HOLD][13.0] Add job_auto_delay decorator#270
guewen wants to merge 1 commit into
OCA:13.0from
guewen:13.0-job_auto_delay

Conversation

@guewen

@guewenguewen commented Oct 28, 2020•
edited
Loading

Copy link
Copy Markdown
Member

This is a new decorator, to use instead of @job on methods,
that transforms a method to a method automatically delayed as job when
called.

A typical use case is when a method in a module we don't control is called
synchronously in the middle of another method, and we'd like all the calls
to this method become asynchronous.

Closes#238

lmignon
lmignon approved these changes Oct 29, 2020
View reviewed changes

@lmignonlmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and good idea! (Code review)

guewen pushed a commit to camptocamp/ddmrp that referenced this pull request Oct 29, 2020
Guewen Baconnier
Add ddmrp_cron_actions_as_job
24919eb
It makes every calls to "cron_actions" run in queue jobs.
The jobs have an identity key with "identity_exact", meaning that only
one occurence of a job for the same buffer with the same arguments
(only_nfp) will be created at a time (e.g. when the state of a
stock.move is changed several times in the same transaction or in
a different transaction in a short timeframe).
It needs OCA/queue#270
@guewenguewen mentioned this pull request Oct 29, 2020
Merged
jgrandguillaume
jgrandguillaume approved these changes Oct 29, 2020
View reviewed changes

@jgrandguillaumejgrandguillaume left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so elegant 👍

simahawk
simahawk approved these changes Oct 29, 2020
View reviewed changes

@simahawksimahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just small glitches.
BTW what about #255 ?

Comment threadqueue_job/job.py
Comment threadqueue_job/job.py Outdated
@guewenguewen mentioned this pull request Oct 29, 2020
Closed
@guewen
guewenforce-pushed the 13.0-job_auto_delay branch from cd49316 to 9659afeCompareOctober 29, 2020 10:45
@guewen

guewen commented Oct 29, 2020

Copy link
Copy Markdown
MemberAuthor

@simahawk I fixed the small glitches and force-pushed directly

etobella
etobella approved these changes Oct 29, 2020
View reviewed changes

@etobellaetobella left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea @guewen this is something I always needed and had to solve using context keys. This is much more cleaner 😄

@guewen

guewen commented Oct 29, 2020

Copy link
Copy Markdown
MemberAuthor

Do not merge yet, I'm investigating an error:

AttributeError: method cron_actions on stock.buffer(5577,) is not allowed to be delayed, it should be decorated with odoo.addons.queue_job.job.job

And I suspect it happens when other modules redefine the same method. To be continued...

@guewenguewen changed the title [13.0] Add job_auto_delay decorator[ON HOLD][13.0] Add job_auto_delay decoratorOct 29, 2020
@guewen

guewen commented Oct 29, 2020

Copy link
Copy Markdown
MemberAuthor

And I suspect it happens when other modules redefine the same method.

I confirm this. I hope I can find a way to prevent this.

@guewen

guewen commented Oct 29, 2020

Copy link
Copy Markdown
MemberAuthor

AttributeError: method cron_actions on stock.buffer(5577,) is not allowed to be delayed, it should be decorated with odoo.addons.queue_job.job.job

This is not an issue only with @job_auto_delay, we have the error with @job.
If I have such dependencies:

module_a
|- module_b
|- module_c

module_b and module_c have no dependencies on each other.

In module_a, we have a method StockMove._update_foo.
In module_b, we add @job on StockMove._update_foo.
In module_c, we have another override of StockMove._update_foo, without decorator.

It seems that depending on the loading order, we'll lose the properties added by @job.

Guewen Baconnier
Add job_auto_delay decorator
68d6bc0
This is a new decorator, to use instead of @job on methods,
that transforms a method to a method automatically delayed as job when
called.
A typical use case is when a method in a module we don't control is called
synchronously in the middle of another method, and we'd like all the calls
to this method become asynchronous.
@guewen
guewenforce-pushed the 13.0-job_auto_delay branch from 9659afe to 68d6bc0CompareOctober 29, 2020 14:10
This was referenced Oct 29, 2020
Closed
Merged
@guewen

guewen commented Nov 2, 2020

Copy link
Copy Markdown
MemberAuthor

I proposed #275 that works by patching the method instead of using a decorator.
It needs #274 that I still have to finalize.

@guewenguewen closed this Nov 2, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrandguillaumejgrandguillaumejgrandguillaume approved these changes
@simahawksimahawksimahawk approved these changes
@lmignonlmignonlmignon approved these changes
@etobellaetobellaetobella approved these changes

Assignees

No one assigned

Labels

approvedneeds fixing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature] Add job_auto_delay decorator

6 participants

@guewen@jgrandguillaume@simahawk@lmignon@etobella@OCA-git-bot