Skip to content

[14.0] mig queue job rebased - #286

Closed
sebastienbeau wants to merge 4 commits into
OCA:14.0from
akretion:14.0-mig-queue_job_rebased
Closed

[14.0] mig queue job rebased#286
sebastienbeau wants to merge 4 commits into
OCA:14.0from
akretion:14.0-mig-queue_job_rebased

Conversation

@sebastienbeau

@sebastienbeausebastienbeau commented Nov 20, 2020

Copy link
Copy Markdown
Member

The queue job in V14 is ready \o/

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@sebastienbeausebastienbeau added this to the 14.0 milestone Nov 20, 2020
@sebastienbeausebastienbeau changed the title 14.0 mig queue job rebased[14.0] mig queue job rebasedNov 20, 2020

@guewenguewen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, code looks good. Thanks for handling this 😊

@t-900-a

Copy link
Copy Markdown

Untested, code looks good. Thanks for handling this 😊

Are there any sample modules that I can run to test this?

Trying to do what I can to help this along.

ty

@guewen

Copy link
Copy Markdown
Member

@sebastienbeau travis was not triggered, maybe you should amend the last commit?

@guewen

guewen commented Nov 27, 2020

Copy link
Copy Markdown
Member

In runbot logs:

2020-11-20 15:44:58,072 159 WARNING openerp_test odoo.fields: Field queue.job.record_ids: unknown parameter '_base_type', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
2020-11-20 15:44:58,072 159 WARNING openerp_test odoo.fields: Field queue.job.records: unknown parameter '_base_type', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
2020-11-20 15:44:58,072 159 WARNING openerp_test odoo.fields: Field queue.job.args: unknown parameter '_base_type', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
2020-11-20 15:44:58,072 159 WARNING openerp_test odoo.fields: Field queue.job.kwargs: unknown parameter '_base_type', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
2020-11-20 15:44:58,079 159 WARNING openerp_test odoo.fields: Field queue.job.function.retry_pattern: unknown parameter '_base_type', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
2020-11-20 15:44:58,079 159 WARNING openerp_test odoo.fields: Field queue.job.function.related_action: unknown parameter '_base_type', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it

I suppose this should be done for _base_type (used by the field type JobSerialized):

field.type = 'job_serialized' and name == '_base_type'

I do not quite get this new _valid_field_parameter, worth to check what I wrote...

@guewen

Copy link
Copy Markdown
Member

Actually, the diff to look at for the JobSerialized field is: https://github.com/odoo/odoo/pull/48705/files
_slots has been replaced by class attributes. I think _valid_field_parameter will not be required if the JobSerialized field is changed the same way.

@guewen

Copy link
Copy Markdown
Member

Are there any sample modules that I can run to test this?

Trying to do what I can to help this along.

Thanks @t-900-a for your proposal to help!
I guess none of the module using the queue are ported yet, however at least there is now a way to generate dummy jobs when queue_job is installed, by doing a GET on http://odoo.example.com:8069/queue_job/create_test_job
Maybe not worth to test until the last changes on the JobSerialized field are done though?

@aliencrash

Copy link
Copy Markdown

Are there any sample modules that I can run to test this?
Trying to do what I can to help this along.

Thanks @t-900-a for your proposal to help!
I guess none of the module using the queue are ported yet, however at least there is now a way to generate dummy jobs when queue_job is installed, by doing a GET on http://odoo.example.com:8069/queue_job/create_test_job
Maybe not worth to test until the last changes on the JobSerialized field are done though?

I already ported my module and just dependent on this one kkkk.

@guewenguewen mentioned this pull request Nov 28, 2020
@guewen

Copy link
Copy Markdown
Member

To be continued on #289 :) Thanks!

@guewenguewen closed this Nov 28, 2020
@guewenguewen mentioned this pull request Nov 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@sebastienbeau@OCA-git-bot@t-900-a@guewen@aliencrash@eantones