Uh oh!
There was an error while loading. Please reload this page.
[13.0] Remove initial create notification and follower - #302
Merged
Conversation
guewenforce-pushed
the
13.0-no-initial-mail-follower
branch
from
February 1, 2021 09:45
f2de0b9 to
c00b931Compareguewenforce-pushed
the
13.0-no-initial-mail-follower
branch
from
February 1, 2021 10:43
c00b931 to
4c2a24aCompareguewenforce-pushed
the
13.0-no-initial-mail-follower
branch
from
February 1, 2021 10:54
4c2a24a to
b430450Compareguewenforce-pushed
the
13.0-no-initial-mail-follower
branch
from
February 1, 2021 11:21
b430450 to
b8b344dCompare
Everytime a job is created, a mail.message "Queue Job created" is created. This is useless, as we already have the creation date and user, and nobody will ever want to receive a notification for a created job anyway. Removing the on creation auto-subscription of the user that created the job makes sense as well since we automatically subscribe the queue job managers for failures. Add the owner of the jobs to the followers on failures only as well. It allows to remove a lot of insertions of records (and of deletions when autovacuuming jobs).
guewenforce-pushed
the
13.0-no-initial-mail-follower
branch
from
February 1, 2021 11:22
b8b344d to
510dc4fCompareguewen
commented
Feb 3, 2021
MemberAuthor
Added a small benchmark in the description |
sebalix
approved these changes
Feb 3, 2021
etobella
approved these changes
Feb 3, 2021
TDu
approved these changes
Feb 3, 2021
simahawk
commented
Feb 4, 2021
Contributor
/ocabot merge minor |
OCA-git-bot
commented
Feb 4, 2021
Contributor
This PR looks fantastic, let's merge it! |
OCA-git-bot
commented
Feb 4, 2021
Contributor
Congratulations, your PR was merged at 563db61. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everytime a job is created, a mail.message "Queue Job created" is
created. This is useless, as we already have the creation date and user,
and nobody will ever want to receive a notification for a created job
anyway.
Removing the auto-subscription of the user that created the job makes
sense as well since we automatically subscribe the queue job managers
for failures, and we don't send other notifications.
It allows to remove a lot of insertions of records (and of deletions
when autovacuuming jobs).
Rough benchmark when generating jobs for ddmrp buffers (it includes some base
time to fetch the ddmrp buffers too). 9191 jobs were created: