Skip to content

[FIX] 14.0 doctests hidden errors - #338

Merged
OCA-git-bot merged 5 commits into
OCA:14.0from
PieterPaulussen:fix/doctests-hidden-errors
May 19, 2021
Merged

[FIX] 14.0 doctests hidden errors#338
OCA-git-bot merged 5 commits into
OCA:14.0from
PieterPaulussen:fix/doctests-hidden-errors

Conversation

@PieterPaulussen

@PieterPaulussenPieterPaulussen commented Apr 21, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

At the moment, a doctest that fails is not registered in the output of the test results.
I have tested this hypothesis here: #336 where the tests do not fail, even though there is a clear error present!

@PieterPaulussenPieterPaulussen changed the title Fix/doctests hidden errors[FIX] 14.0 doctests hidden errorsApr 21, 2021
@StefanRijnhart

StefanRijnhart commented Apr 21, 2021

Copy link
Copy Markdown
Member

Oh, but this way we are stuck again with the meaningless test names, which is why Nils used a wrapper class...

2021-04-21 13:08:02,987 5794 INFO openerp_test doctest: Starting DocTestCase.runTest ...
2021-04-21 13:08:02,989 5794 INFO openerp_test doctest: Starting DocTestCase.runTest ...
2021-04-21 13:08:02,990 5794 INFO openerp_test doctest: Starting DocTestCase.runTest ...
2021-04-21 13:08:02,990 5794 INFO openerp_test doctest: Starting DocTestCase.runTest ...

@PieterPaulussen

PieterPaulussen commented Apr 29, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I have refactored the tests a bit and now the output looks like:

2021-04-29 11:06:09,567 22509 INFO odoo odoo.addons.queue_job.tests.common: Starting OdooDocTestCase.runTest ... 2021-04-29 11:06:09,567 22509 INFO odoo odoo.addons.queue_job.tests.common: Running tests for odoo.addons.queue_job.jobrunner.channels.ChannelManager

@PieterPaulussenPieterPaulussen mentioned this pull request May 3, 2021
Closed
StefanRijnhart
StefanRijnhart reviewed May 3, 2021
View reviewed changes
Comment threadqueue_job/tests/common.py Outdated
@StefanRijnhart

StefanRijnhart commented May 3, 2021

Copy link
Copy Markdown
Member

@nilshamerlinck what do you think of this solution to the problem of doctest failures going unnoticed?

@guewen

guewen commented May 19, 2021

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented May 19, 2021

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-338-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit b1912c7 into OCA:14.0May 19, 2021
@OCA-git-bot

OCA-git-bot commented May 19, 2021

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at b1912c7. Thanks a lot for contributing to OCA. ❤️

@simahawksimahawk mentioned this pull request Mar 14, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhartStefanRijnhartStefanRijnhart approved these changes

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PieterPaulussen@StefanRijnhart@guewen@OCA-git-bot@nilshamerlinck