Skip to content

[IMP] queue_job: Add cancelled state to queue.job - #347

Merged
OCA-git-bot merged 2 commits into
OCA:12.0from
VanMoof:12.0-queue_job-cancelled_state
Sep 3, 2021
Merged

[IMP] queue_job: Add cancelled state to queue.job#347
OCA-git-bot merged 2 commits into
OCA:12.0from
VanMoof:12.0-queue_job-cancelled_state

Conversation

@hbrunn

@hbrunnhbrunn commented May 14, 2021•
edited
Loading

Copy link
Copy Markdown
Member

I'll add tests when we agree this is how it should work

@hbrunnhbrunn mentioned this pull request May 14, 2021
Closed
guewen
guewen reviewed May 18, 2021
View reviewed changes
Comment threadqueue_job/job.py Outdated
@guewen

guewen commented May 18, 2021

Copy link
Copy Markdown
Member

I'll add tests when we agree this is how it should work

It looks good to me :)

StefanRijnhart
StefanRijnhart reviewed May 20, 2021
View reviewed changes
Comment threadqueue_job/views/queue_job_views.xml Outdated
@hbrunn
hbrunnforce-pushed the 12.0-queue_job-cancelled_state branch from 0279dd3 to 32dea7bCompareMay 21, 2021 04:18
@hbrunn

hbrunn commented May 21, 2021

Copy link
Copy Markdown
MemberAuthor

thanks all, changed according to comments

StefanRijnhart
StefanRijnhart reviewed May 21, 2021
View reviewed changes
Comment threadqueue_job/models/queue_job.py Outdated
@StefanRijnhart

StefanRijnhart commented May 21, 2021

Copy link
Copy Markdown
Member

Were you still going to add a test?

@hbrunn
hbrunnforce-pushed the 12.0-queue_job-cancelled_state branch from 47ff477 to 5045d6dCompareMay 21, 2021 17:42
@hbrunn

hbrunn commented May 21, 2021

Copy link
Copy Markdown
MemberAuthor

now with the promised tests. Anybody have permissions to fix runbot?

StefanRijnhart
StefanRijnhart approved these changes May 22, 2021
View reviewed changes

@StefanRijnhartStefanRijnhart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

guewen
guewen approved these changes May 22, 2021
View reviewed changes

@guewenguewen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
About runbot, I don't.

@hbrunnhbrunn mentioned this pull request Jun 11, 2021
Closed
@dreispt

dreispt commented Jul 29, 2021

Copy link
Copy Markdown
Member

@hbrunn Can you please resolve the conflicts? Thanks!

@hbrunn
hbrunnforce-pushed the 12.0-queue_job-cancelled_state branch from 5045d6d to 6299faaCompareJuly 29, 2021 16:51
@hbrunn

hbrunn commented Jul 29, 2021

Copy link
Copy Markdown
MemberAuthor

@dreispt thanks for the heads up!

@hbrunn
hbrunnforce-pushed the 12.0-queue_job-cancelled_state branch from 6a7db7d to 9720915CompareJuly 30, 2021 00:37
@guewen

guewen commented Sep 3, 2021

Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-347-by-guewen-bump-minor, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit bcdebba into OCA:12.0Sep 3, 2021
@OCA-git-bot

OCA-git-bot commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at fab0256. Thanks a lot for contributing to OCA. ❤️

@dzungtran89dzungtran89 mentioned this pull request Dec 14, 2021
Merged
@sbidoulsbidoul mentioned this pull request May 1, 2023
Open
@sbidoulsbidoul added this to the 12.0 milestone May 2, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawksimahawksimahawk left review comments
@guewenguewenguewen approved these changes
@StefanRijnhartStefanRijnhartStefanRijnhart approved these changes

Assignees

No one assigned

Labels

approvedmerged 🎉

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

7 participants

@hbrunn@guewen@StefanRijnhart@dreispt@OCA-git-bot@simahawk@sbidoul