Skip to content

[FIX] queue_job: Migrations raising errors - #356

Merged
OCA-git-bot merged 1 commit into
OCA:13.0from
tegin:13.0-fix-migrations
Jun 29, 2021
Merged

[FIX] queue_job: Migrations raising errors#356
OCA-git-bot merged 1 commit into
OCA:13.0from
tegin:13.0-fix-migrations

Conversation

@etobella

@etobellaetobella commented Jun 22, 2021

Copy link
Copy Markdown
Member

When executing OpenUpgrade with a database that didn't have queue_job but a module change on 13.0 required it, several errors where raised (I don't know why, but OpenUpgrade executed the migrations). In order to solve them, I had to change the scripts applying this changes

pedrobaeza
pedrobaeza reviewed Jun 22, 2021
View reviewed changes
Comment threadqueue_job/migrations/13.0.3.2.0/pre-migration.py Outdated


def migrate(cr, version):
if not column_exists(cr, "queue_job", "record_ids"):

@pedrobaezapedrobaezaJun 22, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this column will exist ever. It seems a one2many/many2many field.

@etobellaetobellaJun 22, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the problem is that the table does not exist, modified checking the existance of the table

@etobellaetobella changed the title [FIX] queue_jobs: Migrations raising errors[FIX] queue_job: Migrations raising errorsJun 22, 2021
@etobella
etobellaforce-pushed the 13.0-fix-migrations branch from ae671fa to cb99f27CompareJune 22, 2021 13:15
@pedrobaezapedrobaeza added this to the 13.0 milestone Jun 22, 2021
@etobellaetobella mentioned this pull request Jun 22, 2021
Closed
1 task
@etobella
etobellaforce-pushed the 13.0-fix-migrations branch from cb99f27 to 3b3652eCompareJune 22, 2021 13:58
@OCA-git-bot

OCA-git-bot commented Jun 27, 2021

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@guewen

guewen commented Jun 29, 2021

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-356-by-guewen-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 29, 2021
@OCA-git-bot
Merge PR#356into 13.0
f8bdbae
Signed-off-by guewen
@OCA-git-bot

OCA-git-bot commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-356-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 48a97e0 into OCA:13.0Jun 29, 2021
@OCA-git-bot

OCA-git-bot commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 48a97e0. Thanks a lot for contributing to OCA. ❤️

@dzungtran89dzungtran89 mentioned this pull request Nov 24, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guewenguewenguewen approved these changes
@pedrobaezapedrobaezapedrobaeza approved these changes

Assignees

No one assigned

Labels

approvedmerged 🎉ready to merge

Projects

None yet

Milestone

13.0

Development

Successfully merging this pull request may close these issues.

4 participants

@etobella@OCA-git-bot@guewen@pedrobaeza