Skip to content

[14.0][MIG] - queue_job_subscribe - #359

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
acsone:14.0-queue_job_subscribe-sbj
Sep 16, 2021
Merged

[14.0][MIG] - queue_job_subscribe#359
OCA-git-bot merged 1 commit into
OCA:14.0from
acsone:14.0-queue_job_subscribe-sbj

Conversation

@sbejaoui

@sbejaouisbejaoui commented Jul 9, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@sbejaoui
sbejaouiforce-pushed the 14.0-queue_job_subscribe-sbj branch from 5efa961 to a756d10CompareJuly 9, 2021 12:36
rousseldenis
rousseldenis approved these changes Aug 3, 2021
View reviewed changes

@rousseldenisrousseldenis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@BT-cserra

BT-cserra commented Sep 16, 2021•
edited
Loading

Copy link
Copy Markdown

Hello @sbejaoui do you have time to merge the conflicts so that this can be merged? I can propose a PR on your branch to fix them if this is more convenient for you. Thanks.

@sbejaoui
sbejaouiforce-pushed the 14.0-queue_job_subscribe-sbj branch from a756d10 to d9e0a72CompareSeptember 16, 2021 07:40
@sbejaoui

sbejaoui commented Sep 16, 2021

Copy link
Copy Markdown
ContributorAuthor

Hello @sbejaoui do you have time to merge the conflicts so that this can be merged? I can propose a PR on your branch to fix them if this is more convenient for you. Thanks.

Hi @BT-cserra , it's fixed now

@BT-cserra

BT-cserra commented Sep 16, 2021

Copy link
Copy Markdown

Hello @sbejaoui do you have time to merge the conflicts so that this can be merged? I can propose a PR on your branch to fix them if this is more convenient for you. Thanks.

Hi @BT-cserra , it's fixed now

Many thanks :)

@OCA-git-bot

OCA-git-bot commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BT-cserra

BT-cserra commented Sep 16, 2021

Copy link
Copy Markdown

Hello @rousseldenis can you please trigger a merge on this one if it's fine for you?

@rousseldenis

rousseldenis commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

Hello @rousseldenis can you please trigger a merge on this one if it's fine for you?

Unfortunately, don't have power here :-)

@OCA/core-maintainers

@dreispt

dreispt commented Sep 16, 2021

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

@dreispt The merge process could not start, because of exception 403 Must have admin access to view repository collaborators..

@dreispt

dreispt commented Sep 16, 2021

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

@dreispt The merge process could not start, because of exception 403 Must have admin access to view repository collaborators..

@guewen

guewen commented Sep 16, 2021

Copy link
Copy Markdown
Member

What is this error?

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-359-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 04b6340 into OCA:14.0Sep 16, 2021
@OCA-git-bot

OCA-git-bot commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at eb83285. Thanks a lot for contributing to OCA. ❤️

@BT-cserra

BT-cserra commented Sep 17, 2021

Copy link
Copy Markdown

@rousseldenis@dreispt@guewen many thanks!

@rousseldenis

rousseldenis commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

What is this error?

/ocabot merge nobump

That's a bug reported recently as GitHub API access rights has changed.

@simahawk

simahawk commented May 25, 2022

Copy link
Copy Markdown
Contributor

/ocabot migration queue_job_subscribe

@OCA-git-botOCA-git-bot added this to the 14.0 milestone May 25, 2022
@OCA-git-botOCA-git-bot mentioned this pull request May 25, 2022
Closed
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@BT-cserraBT-cserraBT-cserra approved these changes
@BT-aestebanezBT-aestebanezBT-aestebanez approved these changes
@rousseldenisrousseldenisrousseldenis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedmerged 🎉ready to merge

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

8 participants

@sbejaoui@BT-cserra@OCA-git-bot@rousseldenis@dreispt@guewen@simahawk@BT-aestebanez