Skip to content

[15.0] Migration of queue_job - #384

Merged
OCA-git-bot merged 7 commits into
OCA:15.0from
guewen:15.0-mig-queue_job
Nov 2, 2021
Merged

[15.0] Migration of queue_job#384
OCA-git-bot merged 7 commits into
OCA:15.0from
guewen:15.0-mig-queue_job

Conversation

@guewen

Copy link
Copy Markdown
Member

This is the work from @romi477 from #378 rebased on 15.0

@ventor-dev

Copy link
Copy Markdown

@guewen so you will finish it or @romi477 should do smth? We need this module for our customer...

@pedrobaeza

Copy link
Copy Markdown
Member

@guewen maybe you need to run the copier template (https://github.com/OCA/oca-addons-repo-template) over 15.0 for having the proper metafiles.

@guewen

Copy link
Copy Markdown
MemberAuthor

maybe you need to run the copier template (https://github.com/OCA/oca-addons-repo-template) over 15.0 for having the proper metafiles.

Thanks @pedrobaeza! I fixed the base files now.

Reading the logs, it looks like it tries to install queue_job, which is a dependency of test_queue_job. The pip installable wheel for queue_job does not exist yet. @sbidoul did you see something like this already?

Run oca_install_addons
+ setuptools-odoo-get-requirements --include-addons --addons-dir .
+ cat test-requirements.txt
odoo-addon-queue_job>=15.0dev,<15.1dev
odoo>=15.0a,<15.1dev
requests
+ pip install -r test-requirements.txt
Looking in indexes: https://wheelhouse.odoo-community.org/oca-simple-and-pypi
ERROR: Could not find a version that satisfies the requirement odoo-addon-queue_job<15.1dev,>=15.0dev (from versions: none)
ERROR: No matching distribution found for odoo-addon-queue_job<15.1dev,>=15.0dev
Error: Process completed with exit code 1.

@sbidoul

sbidoul commented Nov 1, 2021

Copy link
Copy Markdown
Member

It's a bug. Addons of the current repo should not be added to test-requirements.txt. I'll look into it. (acsone/setuptools-odoo#67)

@etobella

Copy link
Copy Markdown
Member

Just one question. Can we delete test_queue_job and use odoo_test_helper in order to create the models in the tests. Something similar to https://github.com/OCA/edi/blob/14.0/edi_oca/tests/test_consumer_mixin.py ?

Comment threadqueue_job/fields.py Outdated
@sbidoul

Copy link
Copy Markdown
Member

OCA/oca-ci#16 should fix it. We can restart the tests here as soon as the oca-ci images are rebuilt.

@sbidoul

Copy link
Copy Markdown
Member

🍏

@guewen

Copy link
Copy Markdown
MemberAuthor

Wow, many thanks @sbidoul.

@guewen

Copy link
Copy Markdown
MemberAuthor

@etobella Why not, if anyone has time to dedicate to this...

@simahawksimahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@guewen

guewen commented Nov 2, 2021

Copy link
Copy Markdown
MemberAuthor

@guewen so you will finish it or @romi477 should do smth? We need this module for our customer...

@ventor-dev He can review and approve this PR :)

@ventor-dev

Copy link
Copy Markdown

@guewen@sbidoul when do you think that can be merged?

Also will it be also published to Odoo Apps?

@guewen

Copy link
Copy Markdown
MemberAuthor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-384-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 8168ca0. Thanks a lot for contributing to OCA. ❤️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@guewen@ventor-dev@pedrobaeza@sbidoul@etobella@OCA-git-bot@simahawk@romi477